Skip to content

make the whole projectContext still a reference after safeCloneDeep#12826

Merged
cderv merged 1 commit intomainfrom
no-projectContext-clone
May 26, 2025
Merged

make the whole projectContext still a reference after safeCloneDeep#12826
cderv merged 1 commit intomainfrom
no-projectContext-clone

Conversation

@cderv
Copy link
Copy Markdown
Member

@cderv cderv commented May 26, 2025

projectContext should not be deep cloned. Only reference needs to be passed in the codebase.

This follows the works on

It happens that the whole projectContext object should not be cloned. Only reference to the created object should be passed throughout our codebase.

So a clone method is added as an identity function to work with our safeCloneDeep() logic.

This PR is quite simple but is there to check all our tests are passing.

This splits some changes from

and this PR is required to merge #12809

projectContext should not be deep cloned. Only reference needs to be passed in the codebase.
@posit-snyk-bot
Copy link
Copy Markdown
Collaborator

posit-snyk-bot commented May 26, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@cderv cderv merged commit 80aa8dd into main May 26, 2025
49 checks passed
@cderv cderv deleted the no-projectContext-clone branch May 26, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants