Reconfigure stdin encoding to UTF-8#13748
Merged
cderv merged 2 commits intoquarto-dev:mainfrom Jan 14, 2026
Merged
Conversation
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
cderv
approved these changes
Jan 14, 2026
Member
cderv
left a comment
There was a problem hiding this comment.
Sorry for the delay on this one !
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a UTF-8 encoding issue on Windows when reading JSON input from stdin. The problem occurs when processing documents containing non-ASCII characters (e.g., Chinese), which causes JSON parsing to fail due to incorrect encoding.
Changes:
- Added UTF-8 encoding reconfiguration for stdin before reading JSON input
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
🤔 Why copilot is triggering now... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Welcome to the quarto GitHub repo!
We are always happy to hear feedback from our users.
To file a pull request, please follow these instructions carefully: https://yihui.org/issue/#bug-reports
If you're a collaborator from outside
quarto-devmaking changes larger than a typo, please make sure you have filed an individual or corporate contributor agreement. You can send the signed copy to jj@rstudio.com.Also, please complete and keep the checklist below.
Description
Please describe your PR here.
On Windows, we need to use utf-8 to read the json correctly.
This one line change fixes the json load error on Windows writingdocuments containing Chinese for me.
Checklist
I have (if applicable):