Fix stack trace shown for Typst compilation errors#13957
Merged
gordonwoodhull merged 2 commits intomainfrom Feb 17, 2026
Merged
Fix stack trace shown for Typst compilation errors#13957gordonwoodhull merged 2 commits intomainfrom
gordonwoodhull merged 2 commits intomainfrom
Conversation
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
gordonwoodhull
force-pushed
the
bugfix/13942
branch
from
08f7808 to
df9c437
Compare
gordonwoodhull
force-pushed
the
bugfix/13942
branch
from
a9bcc58 to
c778d76
Compare
Allows testing for both presence AND absence of specific messages in a single test by passing an array to printsMessage. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Use ErrorEx with printStack=false so users see only the Typst error message without a confusing internal stack trace. Fixes #13942 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
gordonwoodhull
force-pushed
the
bugfix/13942
branch
from
c778d76 to
612621d
Compare
cderv
reviewed
Feb 18, 2026
Member
There was a problem hiding this comment.
Just curious, as there is no test associated with this change. What is the syntax that is enabled by this change?
Thanks
Member
Author
There was a problem hiding this comment.
This suppresses the stack trace when showing a Typst failure in a production (packaged) build.
It can’t be tested because we don’t currently do any significant testing of production builds, and the technique only works in production.
(As developers we’re used to stack traces, but at least in theory we shouldn’t be showing them for expected/known failures in prod. I don’t think we’re very good at this.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ErrorExwithprintStack=falsefor clean user-facing errorsprintsMessagechecks in smoke tests (enabling tests for both presence AND absence of messages)Fixes #13942
Test plan
🤖 Generated with Claude Code