[backport] Fix transient .quarto_ipynb files accumulating during preview#14288
Merged
[backport] Fix transient .quarto_ipynb files accumulating during preview#14288
Conversation
Preview re-renders delete the fileInformationCache entry to pick up file changes, but this loses track of the transient .quarto_ipynb path. The collision-avoidance loop in jupyter.ts target() then sees the old file on disk and creates numbered variants (_1, _2, etc.) that are never cleaned up until preview exits. Add invalidateForFile() to FileInformationCacheMap that cleans up any transient notebook file from disk before removing the cache entry. Replace the bare delete() call in renderForPreview() with this method. Fixes #14281
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Backport of the
invalidateForFile()fix from #14287.When previewing a
.qmdwith Jupyter execution, transient.quarto_ipynbfiles accumulate on each re-render (_1,_2, etc.) and persist on disk even withkeep-ipynb: false. Regression introduced in v1.9 by #13804.renderForPreview()deletes the cache entry before each re-render but does not delete the old transient notebook file from disk. The collision-avoidance loop intarget()sees the existing file and creates a numbered variant.The fix adds
invalidateForFile()toFileInformationCacheMapwhich deletes the transient file before removing the cache entry.The structural fix (passing
ProjectContextfromcmd.tstopreview()) is not backported — it is an improvement that eliminates a pre-existing double-context creation, not a v1.9 regression.Fixes #14281