Improve fixupStreams output merging logic#8477
Closed
loneguardian wants to merge 2 commits intoquarto-dev:mainfrom
Closed
Improve fixupStreams output merging logic#8477loneguardian wants to merge 2 commits intoquarto-dev:mainfrom
loneguardian wants to merge 2 commits intoquarto-dev:mainfrom
Conversation
- Fix fixupStreams altering order of output when stream outputs are interlaced with data output
- Fix indentation
Author
|
I need input on the changelog part, if it is needed at all. |
Member
|
We definitely would need a changelog entry on But before you go any further, I'd like to make sure that we want this change, and that the original behavior wasn't there for a specific reason. @jjallaire, @dragonstyle, do you remember? I wasn't around when our Jupyter code was first written. |
Member
|
#8473 has been fixed by a different commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is a proposed bugfix for #8473
Minimal reproducible repo is at https://github.com/loneguardian/quarto-cli-issue-8473
This PR:
fixupStreams()so that it only groups adjacent stream outputs, instead of all stream outputs.Referring to the original intended fix for #4968:
Checklist
I have (if applicable):