Skip to content

Improve fixupStreams output merging logic#8477

Closed
loneguardian wants to merge 2 commits intoquarto-dev:mainfrom
loneguardian:bugfix/8473
Closed

Improve fixupStreams output merging logic#8477
loneguardian wants to merge 2 commits intoquarto-dev:mainfrom
loneguardian:bugfix/8473

Conversation

@loneguardian
Copy link
Copy Markdown

Description

This PR is a proposed bugfix for #8473

Minimal reproducible repo is at https://github.com/loneguardian/quarto-cli-issue-8473

This PR:

  • Improve the logic of fixupStreams() so that it only groups adjacent stream outputs, instead of all stream outputs.

Referring to the original intended fix for #4968:

  • I am unsure whether this PR will cause regression
  • I am guessing it is unlikely to cause regression.

Checklist

I have (if applicable):

  • filed a contributor agreement. [In progress]
  • referenced the GitHub issue this PR closes
  • updated the appropriate changelog [not sure which file]

- Fix fixupStreams altering order of output when stream outputs are interlaced with data output
- Fix indentation
@loneguardian
Copy link
Copy Markdown
Author

I need input on the changelog part, if it is needed at all.

@cscheid
Copy link
Copy Markdown
Member

cscheid commented Jan 29, 2024

We definitely would need a changelog entry on news/changelog-1.5.md.

But before you go any further, I'd like to make sure that we want this change, and that the original behavior wasn't there for a specific reason. @jjallaire, @dragonstyle, do you remember? I wasn't around when our Jupyter code was first written.

@cscheid cscheid added this to the v1.6 milestone Jun 27, 2024
@cscheid cscheid modified the milestones: v1.6, v1.7 Nov 22, 2024
@cscheid
Copy link
Copy Markdown
Member

cscheid commented Dec 12, 2024

#8473 has been fixed by a different commit

@cscheid cscheid closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants