deno - replace deprecated Deno.run with Deno.Command

[cscheid]

Closes #8891.

[cscheid]

This is a bit obnoxious. Using Deno.Command crashes command.output() with a failed assertion deep into the Deno runtime:

Stack trace:
    at assert (ext:deno_web/00_infra.js:374:11)
    at readableStreamError (ext:deno_web/06_streams.js:2479:3)
    at readableStreamCollectIntoUint8Array (ext:deno_web/06_streams.js:1039:7)
    at eventLoopTick (ext:core/01_core.js:183:11)
    at async Promise.all (index 1)
    at async ChildProcess.output (ext:runtime/40_process.js:295:49)
    at async execProcess (file:///Users/cscheid/repos/github/quarto-dev/quarto-cli/src/core/process.ts:175:20)
    at async pandocListFormats (file:///Users/cscheid/repos/github/quarto-dev/quarto-cli/src/core/pandoc/pandoc-formats.ts:17:18)

(The CI output doesn't show this stack trace, I obtained it locally)

[cscheid]

We're blocked here until we upgrade Deno, I think.

But we're blocked on upgrading Deno until we confirm that the fix for denoland/deno#22180 has landed and resolves our issues. It seems that Deno v1.40.3 fixed that problem, so we should try again.

[cscheid]

This PR is currently blocked by a Deno v1.41.0 bug with the following repro:

deno_repro.ts

async function processOutput(iterator: AsyncIterable<Uint8Array>): Promise<string> {
  const decoder = new TextDecoder();
  let outputText = "";
  for await (const chunk of iterator) {
    const text = decoder.decode(chunk);
    outputText += text;
  }
  return outputText;
}

async function* iteratorFromStream(stream: ReadableStream<Uint8Array>) {
  const reader = stream.getReader();
  try {
    while (true) {
      const { done, value } = await reader.read();
      if (done) return;
      yield value;
    }
  } finally {
    reader.releaseLock();
  }
}

const command = new Deno.Command("ls", {stdout: "piped", stderr: "piped"});
const process = command.spawn();

const promises: Promise<unknown>[] = [
  processOutput(iteratorFromStream(process.stdout)),
  processOutput(iteratorFromStream(process.stderr)),
];

await Promise.all(promises);

// assertion fails here
const status = await process.output();

$ deno run --allow-all deno_repro.ts
error: Uncaught (in promise) AssertionError: Assertion failed.
const status = await process.output();
               ^
    at assert (ext:deno_web/00_infra.js:374:11)
    at readableStreamError (ext:deno_web/06_streams.js:2529:3)
    at readableStreamCollectIntoUint8Array (ext:deno_web/06_streams.js:1081:7)
    at eventLoopTick (ext:core/01_core.js:153:7)
    at async Promise.all (index 1)
    at async ChildProcess.output (ext:runtime/40_process.js:322:49)
    at async file:///Users/cscheid/Desktop/daily-log/2024/02/28/deno_repro.ts:35:16

[cscheid]

Upstream deno bug report: denoland/deno#22621

[lucacasonato]

We're fixing the upstream bug now, but you can unblock yourself here by using child.status instead of child.output(). child.status just waits for the process to exit, while child.output() also tries to consume stdout and stderr until EOF, which is not necessary in your case, because you do that yourself already.