Skip to content

Commit b188d13

Browse files
committed
Update plan docs: myblog rework done, PR #1815 progress tracked
1 parent 263c4c6 commit b188d13

3 files changed

Lines changed: 19 additions & 12 deletions

File tree

.claude/plans/screenshot/00-index.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ Claude Code is the primary operator. Scripts handle deterministic work (zero AI
3030
| 07 | [07-capture-agent.md](07-capture-agent.md) | `screenshot-capture` agent definition | New |
3131
| 08 | [08-walkthrough-learnings.md](08-walkthrough-learnings.md) | Learnings from Phase 0.5 walkthrough | Updated (all validated, L15 profiles) |
3232
| 09 | [09-pr-1815-screenshot-updates.md](09-pr-1815-screenshot-updates.md) | .qmd changes for PR #1815 (`.include-dark`, alt text) | Updated (all 8 screenshots) |
33-
| 10 | [10-tight-cropping.md](10-tight-cropping.md) | Tight cropping: cleanup eval vs sharp vs Playwright style | New |
33+
| 10 | [10-tight-cropping.md](10-tight-cropping.md) | Tight cropping: cleanup eval vs sharp vs Playwright style | Done (about-pages + myblog) |
3434
| 11 | [11-manifest-schema.md](11-manifest-schema.md) | JSON Schema for manifest validation + help reference | Planned |
3535

3636
## Key Decisions
@@ -45,6 +45,7 @@ Claude Code is the primary operator. Scripts handle deterministic work (zero AI
4545
- **Quarto profiles** for multi-template examples — one shared .qmd, profile configs override template
4646
- **Dark mode**`"dark": true` auto-captures `-dark` variant; clip union ensures identical dimensions
4747
- **Clip over element**`capture.clip` (union bounding box) handles dropdown overflow; `capture.element` clips to element bounds
48+
- **cropBottom/maxHeight** — post-capture image cropping for layouts where trim can't detect blank edges (vertical rules, multi-colored backgrounds)
4849

4950
## File Layout (Session 1 deliverables)
5051

.claude/plans/screenshot/09-pr-1815-screenshot-updates.md

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,15 @@ on the **twitter-to-bluesky** branch, not the screenshot-tool branch:
7878
6. Commit images and .qmd changes together
7979
7. Compression: CI handles it after merge, or run `npm run compress` locally
8080

81-
## What's Already Done on twitter-to-bluesky
82-
83-
Commit `104974f` already handled:
84-
- about-jolla: `.include-dark` + alt text
85-
- navbar-tools: `.include-dark` + alt text
86-
- Line ~112 navbar-tools reference: `.include-dark` + alt text
81+
## Progress
82+
83+
### Done (images cherry-picked to twitter-to-bluesky)
84+
- **About pages** (5): all screenshots captured with trim + zoom, dark variants included
85+
- **myblog**: reworked example (post images, blue navbar, page-layout: full), maxHeight: 640 cropping, dark variant works
86+
- `.include-dark` + alt text for about-jolla and navbar-tools (commit `104974f`)
87+
88+
### Remaining
89+
- **navbar-tools**: images regenerated in worktree but not yet committed/cherry-picked to twitter-to-bluesky
90+
- **sidebar-tools** (tools.png): images regenerated in worktree but not yet committed/cherry-picked; `.include-dark` + alt text still needed in `website-navigation.qmd`
91+
- **myblog**: `.include-dark` + alt text still needed in `website-blog.qmd`
92+
- Remaining `.include-dark` + alt text changes in `website-about.qmd` (4 templates) and `website-navigation.qmd` (sidebar-tools)

.claude/plans/screenshot/10-tight-cropping.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -132,11 +132,11 @@ Rationale:
132132
- Background auto-detected from top-left pixel (handles light + dark)
133133
- Combined with zoom (1.15) for readable fonts + tight layout
134134

135-
**Phase 3 — myblog trim/zoom (separate step):**
136-
- myblog dark mode has a multi-colored background (blue navbar vs dark body) — trim can't detect uniform edges
137-
- The blue band around all sides of the dark screenshot is a pre-existing rendering issue, not trim-related
138-
- Options: fix example project CSS/layout, use cleanup eval to normalize background, or adjust viewport
139-
- Handle in its own investigationdon't block about-page trim rollout
135+
**Phase 3 — myblog rework (done):**
136+
- Updated myblog example to match `quarto create project blog` output: post thumbnail images, `page-layout: full`, `background: primary` on navbar, `posts/_metadata.yml`
137+
- Dark mode works without trim — navbar is muted blue, body is dark gray, no blue band issue
138+
- Used `maxHeight: 640` to crop blank space below content (content ends ~593px in 900px viewport)
139+
- Trim not used for myblogmulti-colored background (navbar vs body) prevents content-aware edge detection
140140

141141
**Phase 4 — Playwright `style` support (future):**
142142
- Add `capture.style` manifest field (CSS string)

0 commit comments

Comments
 (0)