PROJQUAY-10873: fix(mirror): prevent pod loss during securityContext override#1220
Open
Marcusk19 wants to merge 1 commit into
Open
PROJQUAY-10873: fix(mirror): prevent pod loss during securityContext override#1220Marcusk19 wants to merge 1 commit into
Marcusk19 wants to merge 1 commit into
Conversation
…lica count (PROJQUAY-10873) GetReplicasOverrideForComponent returned nil when a component had overrides (e.g. securityContext) but no explicit replicas setting. This caused the middleware to omit the replicas field from SSA, releasing operator ownership and letting Kubernetes revert to 1. Return the default of 2 consistently, matching the behavior when no overrides are set at all. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
e1f893f to
09a5237
Compare
|
@Marcusk19: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan