fix: don't re-download encoder weights when loading a pretrained model#1360
Open
cycsmail wants to merge 1 commit into
Open
fix: don't re-download encoder weights when loading a pretrained model#1360cycsmail wants to merge 1 commit into
cycsmail wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #957.
When you reload a model with
from_pretrained, the encoder weights are already stored in the checkpoint, but the saved config still hasencoder_weightsset (e.g."imagenet"), so smp went and re-downloaded the encoder's pretrained weights anyway. That makes loading fail offline / from a purely local path.This skips the download when the config records
encoder_weights, falling back toNoneso the checkpoint weights are used as-is. An explicitencoder_weights=...passed tofrom_pretrainedstill takes precedence viasetdefault.Added a test that asserts no encoder download happens on reload and that the restored weights match the saved model.