google/global.txt: Can sometimes freak out on Google Images

[brian6932]

Eats every result, regardless of them being spam or not.

[chuahou]

This issue occurs for me as well on a variety of searches.

With the search query "memtest menu" in private browsing, every image result gets eaten for me.

I've tested that with every other filter disabled and only "uBlock-Origin-dev-filter – Google+DuckDuckGo – Global" enabled, the results get eaten; with "uBlock-Origin-dev-filter – Google+DuckDuckGo – Global" disabled, the results do not get eaten.

[chuahou]

It appears the problem is that the filter list selects the .MjjYud element. On the normal search results page, each .MjjYud corresponds to a single search result, which makes it work perfectly. On the image search results page, however, all the search results are wrapped in a .MjjYud, meaning every result gets eaten if at least one result matches one of the blacklisted domains.

[JoshuaZacek]

I've found a fix that seems to work for now, although it allows image results to surface from the site you want to blacklist.

I replaced :upwards(.MjjYud) in the filter with :upwards(.Ww4FFb).

So for example, to block Google results from example.com, you'd use google.com###rso .MjjYud a[href*="example.com"]:upward(.Ww4FFb).

[quenhus]

Hi !
Sorry for the long wait. I can't reproduce this bug. Is it happening now?

[chuahou]

Hi @quenhus, I just checked again and it's still happening now. To reproduce:

1. Use the "uBlock-Origin-dev-filter – Google+DuckDuckGo – Global" filter list, with uBlock Origin on Firefox.
2. In Private Browsing, search "memtest menu" in Google Images. (Direct link)
3. The images get eaten.

The results may vary due to region, language, and other fingerprinting Google might have done; any search term that results in at least one of the images being from a blacklisted site should do the trick. (The CSS classes used might also change depending on some A/B-testing that Google does, or maybe with User-Agent, which might impact whether someone sees this happen or not.)

---

Result:

With the filter turned off:

[eternal-sorrow]

Still happening.

[eternal-sorrow]

The filter is applied to .MjjYud element, but on the images page this element is the whole search results area. So it gets hidden.

[eternal-sorrow]

Need to somehow exclude images page udm=2 from filtering.