From a0cd3a1014eac9e0fbe99bcefcf25d4fdd720a99 Mon Sep 17 00:00:00 2001
From: Aaron <aaaron198@gmail.com>
Date: Sat, 25 Apr 2026 08:48:39 +0900
Subject: [PATCH 1/2] test(ingress): assert every column-writing Buffer method
 has an `_opt` twin

   Adds a meta-test that scans `buffer.rs` and asserts every column-writing
   method (identified by the `N: TryInto<ColumnName<'a>>` bound rather than
   by name prefix) has a matching `_opt` sibling. Catches the case where a
   new method like `uuid` or `column_uuid` lands without its `_opt` twin.

   - Adds `regex` to dev-dependencies
---
 questdb-rs/Cargo.toml              |  1 +
 questdb-rs/src/tests/buffer_opt.rs | 42 ++++++++++++++++++++++++++++++
 2 files changed, 43 insertions(+)

diff --git a/questdb-rs/Cargo.toml b/questdb-rs/Cargo.toml
index 38825bea..4ad51345 100644
--- a/questdb-rs/Cargo.toml
+++ b/questdb-rs/Cargo.toml
@@ -58,6 +58,7 @@ chrono = "0.4.31"
 tempfile = "3"
 webpki-roots = "1.0.1"
 rstest = "0.26.1"
+regex = "1"
 
 [features]
 default = ["sync-sender", "tls-webpki-certs", "ring-crypto"]
diff --git a/questdb-rs/src/tests/buffer_opt.rs b/questdb-rs/src/tests/buffer_opt.rs
index 1ecfe94c..6a1a4428 100644
--- a/questdb-rs/src/tests/buffer_opt.rs
+++ b/questdb-rs/src/tests/buffer_opt.rs
@@ -139,3 +139,45 @@ fn test_buffer_opt_array_some_binary_match() -> TestResult {
 
     Ok(())
 }
+
+#[test]
+fn test_every_column_writing_method_has_opt_variant() {
+    // Meta-test: scan buffer.rs and assert every column-writing method has a
+    // matching `_opt` sibling. Catches the case where someone adds a new
+    // method like `uuid` (à la `symbol`) or `column_uuid` without the
+    // `_opt` companion.
+    //
+    // Column writers are identified by the `N: TryInto<ColumnName<'a>>` bound
+    // rather than by name prefix - so `symbol` and any future unprefixed
+    // additions are caught too. The `[^{]*` segment in the writer regex
+    // matches across newlines (it does not exclude `\n`), so it spans
+    // multi-line `where` clauses without needing dotall.
+    let src = include_str!("../ingress/buffer.rs");
+
+    let pub_fn = regex::Regex::new(r"pub fn (\w+)").unwrap();
+    let writer = regex::Regex::new(r"pub fn (\w+)[^{]*TryInto<ColumnName").unwrap();
+
+    let all_pub_fns: std::collections::HashSet<&str> = pub_fn
+        .captures_iter(src)
+        .map(|c| c.get(1).unwrap().as_str())
+        .collect();
+
+    let writers: Vec<&str> = writer
+        .captures_iter(src)
+        .map(|c| c.get(1).unwrap().as_str())
+        .collect();
+
+    // Guard against a wrong include_str! path silently passing the test.
+    assert!(!writers.is_empty(), "no column writers found — wrong path?");
+
+    let missing: Vec<&&str> = writers
+        .iter()
+        .filter(|n| !n.ends_with("_opt"))
+        .filter(|n| !all_pub_fns.contains(format!("{n}_opt").as_str()))
+        .collect();
+
+    assert!(
+        missing.is_empty(),
+        "Buffer column-writing methods missing `_opt` variants: {missing:?}"
+    );
+}

From 0e9f32132530a2ef3381e2e3e8d2ef668b23653e Mon Sep 17 00:00:00 2001
From: Aaron <aaaron198@gmail.com>
Date: Sat, 25 Apr 2026 09:30:29 +0900
Subject: [PATCH 2/2] test(ingress): anchor `_opt` meta-test regexes to exclude
 doc comments
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Adds `(?m)^\s*` to both regexes so matches must start at indentation, not mid-line. A future `pub fn ...` inside a `///` doc example can no longer  be picked up — which would otherwise silently mask a missing `_opt` win if the same example also referenced `TryInto<ColumnName`.
  Today no doc example triggers this, so behavior is unchanged. The fix is preventative.
---
 questdb-rs/src/tests/buffer_opt.rs | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/questdb-rs/src/tests/buffer_opt.rs b/questdb-rs/src/tests/buffer_opt.rs
index 6a1a4428..d6db89b3 100644
--- a/questdb-rs/src/tests/buffer_opt.rs
+++ b/questdb-rs/src/tests/buffer_opt.rs
@@ -152,10 +152,14 @@ fn test_every_column_writing_method_has_opt_variant() {
     // additions are caught too. The `[^{]*` segment in the writer regex
     // matches across newlines (it does not exclude `\n`), so it spans
     // multi-line `where` clauses without needing dotall.
+    //
+    // The `(?m)^\s*` anchor restricts matches to start at the indentation
+    // of an impl item, so a stray `pub fn ...` inside a `///` doc example
+    // can never be picked up.
     let src = include_str!("../ingress/buffer.rs");
 
-    let pub_fn = regex::Regex::new(r"pub fn (\w+)").unwrap();
-    let writer = regex::Regex::new(r"pub fn (\w+)[^{]*TryInto<ColumnName").unwrap();
+    let pub_fn = regex::Regex::new(r"(?m)^\s*pub fn (\w+)").unwrap();
+    let writer = regex::Regex::new(r"(?m)^\s*pub fn (\w+)[^{]*TryInto<ColumnName").unwrap();
 
     let all_pub_fns: std::collections::HashSet<&str> = pub_fn
         .captures_iter(src)