Skip to content

Commit 09c75b3

Browse files
committed
Fix stale macOS comment in the test pipeline
The build_native.yaml step comment claimed "macOS uses the committed .dylib and is skipped inside the template." Both halves are now false: this branch dropped all committed dylibs and added a macOS build step to build_native.yaml (an active Darwin-conditioned step), so the dylib is compiled fresh on the mac-aarch64 agent like the .so/.dll. The stale comment could mislead a maintainer into skipping macOS in the template, which would hard-break the mac leg since no committed dylib remains. Reword to state that every platform's binary is built on its own native agent and none are committed.
1 parent e34fc1c commit 09c75b3

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

ci/run_tests_pipeline.yaml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -78,10 +78,12 @@ stages:
7878
maven | "$(Agent.OS)"
7979
path: $(HOME)/.m2/repository
8080
displayName: "Cache Maven repository"
81-
# Compile the native libquestdb.so/.dll on the runner (Linux/Windows
82-
# binaries are no longer committed). Must run before the client jar is
83-
# installed so the freshly built lib is packaged into it. macOS uses
84-
# the committed .dylib and is skipped inside the template.
81+
# Compile the native libquestdb shared library on the runner; no
82+
# platform's binary is committed anymore. Must run before the client
83+
# jar is installed so the freshly built lib is packaged into it. The
84+
# template builds the right artifact for the current native agent --
85+
# Linux (.so), Windows (.dll), and macOS (.dylib) alike (see
86+
# build_native.yaml).
8587
- template: build_native.yaml
8688
- bash: |
8789
BRANCH="${SYSTEM_PULLREQUEST_SOURCEBRANCH:-$BUILD_SOURCEBRANCHNAME}"

0 commit comments

Comments
 (0)