Commit 0a9c3d6
De-reflect cursor tests; de-flake poison timing
Two test-quality fixes in the send-loop cursor suite; no production
behavior change.
De-reflection. CatchUpAlignmentTest, PoisonFrameTest, TornDictGuardTest
and MirrorLeakTest reached into CursorWebSocketSendLoop by reflection --
reading private constants and fields, invoking private methods, and
writing private state -- so a rename broke them as a runtime
ReflectiveOperationException instead of a compile error. Add @testonly
accessors and thin ...ForTest wrappers on CursorWebSocketSendLoop, each
delegating verbatim to the same private member, and make
forceMirrorSeedFailureForTest public; then rewire the four tests to call
them. The rewrites drive the identical production paths, and the
mirror-overflow guard now catches the exact public LineSenderException
type rather than unwrapping an InvocationTargetException.
De-flake. PoisonFrameTest asserted absolute wall-clock bounds -- a
recycle is "immediate" under 300 ms, and a recycle count fits a fixed
sleep window -- that a CI GC pause or starved scheduler can trip.
Replace them with predicates only a real regression fails: consecutive
recycle gaps must clear 3/4 of the reconnect backoff (an unpaced loop's
sub-millisecond gaps fail, while a slow test thread only yields more
paced samples); the deterministic zeroProgressRecycles branch value
(level 0, then 1, then reset on progress); a first*2 <= second relative
bound; and the kept second >= backoff lower bound, which starvation can
only lengthen. Split the dwell test into a huge-window case (threshold
reached, window still open, so no escalation -- asserting poisonStrikes
== 3) and a small-window case crossed by a sleep strictly longer than
the window, which must escalate to the PROTOCOL_VIOLATION terminal.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent 54e21f8 commit 0a9c3d6
5 files changed
Lines changed: 384 additions & 360 deletions
File tree
- core/src
- main/java/io/questdb/client/cutlass/qwp/client/sf/cursor
- test/java/io/questdb/client/test/cutlass/qwp/client/sf/cursor
Lines changed: 145 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
206 | 206 | | |
207 | 207 | | |
208 | 208 | | |
209 | | - | |
| 209 | + | |
210 | 210 | | |
211 | 211 | | |
212 | 212 | | |
| |||
1091 | 1091 | | |
1092 | 1092 | | |
1093 | 1093 | | |
| 1094 | + | |
| 1095 | + | |
| 1096 | + | |
| 1097 | + | |
| 1098 | + | |
| 1099 | + | |
| 1100 | + | |
| 1101 | + | |
| 1102 | + | |
| 1103 | + | |
1094 | 1104 | | |
1095 | 1105 | | |
1096 | 1106 | | |
| |||
2895 | 2905 | | |
2896 | 2906 | | |
2897 | 2907 | | |
| 2908 | + | |
| 2909 | + | |
| 2910 | + | |
| 2911 | + | |
| 2912 | + | |
| 2913 | + | |
| 2914 | + | |
| 2915 | + | |
| 2916 | + | |
| 2917 | + | |
| 2918 | + | |
| 2919 | + | |
| 2920 | + | |
| 2921 | + | |
| 2922 | + | |
| 2923 | + | |
| 2924 | + | |
| 2925 | + | |
| 2926 | + | |
| 2927 | + | |
| 2928 | + | |
| 2929 | + | |
| 2930 | + | |
| 2931 | + | |
| 2932 | + | |
| 2933 | + | |
| 2934 | + | |
| 2935 | + | |
| 2936 | + | |
| 2937 | + | |
| 2938 | + | |
| 2939 | + | |
| 2940 | + | |
| 2941 | + | |
| 2942 | + | |
| 2943 | + | |
| 2944 | + | |
| 2945 | + | |
| 2946 | + | |
| 2947 | + | |
| 2948 | + | |
| 2949 | + | |
| 2950 | + | |
| 2951 | + | |
| 2952 | + | |
| 2953 | + | |
| 2954 | + | |
| 2955 | + | |
| 2956 | + | |
| 2957 | + | |
| 2958 | + | |
| 2959 | + | |
| 2960 | + | |
| 2961 | + | |
| 2962 | + | |
| 2963 | + | |
| 2964 | + | |
| 2965 | + | |
| 2966 | + | |
| 2967 | + | |
| 2968 | + | |
| 2969 | + | |
| 2970 | + | |
| 2971 | + | |
| 2972 | + | |
| 2973 | + | |
| 2974 | + | |
| 2975 | + | |
| 2976 | + | |
| 2977 | + | |
| 2978 | + | |
| 2979 | + | |
| 2980 | + | |
| 2981 | + | |
| 2982 | + | |
| 2983 | + | |
| 2984 | + | |
| 2985 | + | |
| 2986 | + | |
| 2987 | + | |
| 2988 | + | |
| 2989 | + | |
| 2990 | + | |
| 2991 | + | |
| 2992 | + | |
| 2993 | + | |
| 2994 | + | |
| 2995 | + | |
| 2996 | + | |
| 2997 | + | |
| 2998 | + | |
| 2999 | + | |
| 3000 | + | |
| 3001 | + | |
| 3002 | + | |
| 3003 | + | |
| 3004 | + | |
| 3005 | + | |
| 3006 | + | |
| 3007 | + | |
| 3008 | + | |
| 3009 | + | |
| 3010 | + | |
| 3011 | + | |
| 3012 | + | |
| 3013 | + | |
| 3014 | + | |
| 3015 | + | |
| 3016 | + | |
| 3017 | + | |
| 3018 | + | |
| 3019 | + | |
| 3020 | + | |
| 3021 | + | |
| 3022 | + | |
| 3023 | + | |
| 3024 | + | |
| 3025 | + | |
| 3026 | + | |
| 3027 | + | |
| 3028 | + | |
| 3029 | + | |
| 3030 | + | |
| 3031 | + | |
| 3032 | + | |
| 3033 | + | |
| 3034 | + | |
| 3035 | + | |
| 3036 | + | |
| 3037 | + | |
| 3038 | + | |
| 3039 | + | |
| 3040 | + | |
| 3041 | + | |
2898 | 3042 | | |
2899 | 3043 | | |
2900 | 3044 | | |
| |||
0 commit comments