Skip to content

Commit 504721d

Browse files
mtopolnikclaude
andcommitted
Remove dead TYPE_MASK and TYPE_NULLABLE_FLAG
The nullable-flag-in-type-code mechanism was replaced by inline null count encoding. Since the protocol was never released, remove the dead constants and their tests entirely rather than deprecating them. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 6d029fe commit 504721d

2 files changed

Lines changed: 0 additions & 18 deletions

File tree

core/src/main/java/io/questdb/client/cutlass/qwp/protocol/QwpConstants.java

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -209,14 +209,6 @@ public final class QwpConstants {
209209
* Wire format: [nDims (1B)] [dim1_len (4B)]...[dimN_len (4B)] [flattened values (LE)]
210210
*/
211211
public static final byte TYPE_LONG_ARRAY = 0x12;
212-
/**
213-
* Mask for type code without nullable flag.
214-
*/
215-
public static final byte TYPE_MASK = 0x7F;
216-
/**
217-
* High bit indicating nullable column.
218-
*/
219-
public static final byte TYPE_NULLABLE_FLAG = (byte) 0x80;
220212
/**
221213
* Column type: SHORT (int16, little-endian).
222214
*/

core/src/test/java/io/questdb/client/test/cutlass/qwp/protocol/QwpConstantsTest.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -172,16 +172,6 @@ public void testMagicBytesValue() {
172172
Assert.assertEquals((byte) ((MAGIC_MESSAGE >> 24) & 0xFF), expected[3]);
173173
}
174174

175-
@Test
176-
public void testNullableFlag() {
177-
Assert.assertEquals((byte) 0x80, TYPE_NULLABLE_FLAG);
178-
Assert.assertEquals(0x7F, TYPE_MASK);
179-
180-
// Test nullable type extraction
181-
byte nullableInt = (byte) (TYPE_INT | TYPE_NULLABLE_FLAG);
182-
Assert.assertEquals(TYPE_INT, nullableInt & TYPE_MASK);
183-
}
184-
185175
@Test
186176
public void testSchemaModes() {
187177
Assert.assertEquals(0x00, SCHEMA_MODE_FULL);

0 commit comments

Comments
 (0)