Skip to content

Commit 8061ec6

Browse files
committed
docs(client): drop phantom NACK-placeholder enqueue from durable-ack javadoc
enqueuePendingOk has a single call site -- the OK-frame branch. NACK frames route to handleServerRejection, which either latches a terminal or recycles the connection; neither enqueues a pending entry. Remove the stale 'NACK frames enqueue as trivially-durable empty placeholders' sentences from enqueuePendingOk and drainPendingDurable javadoc.
1 parent 6b58a8c commit 8061ec6

1 file changed

Lines changed: 6 additions & 5 deletions

File tree

core/src/main/java/io/questdb/client/cutlass/qwp/client/sf/cursor/CursorWebSocketSendLoop.java

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1321,7 +1321,7 @@ private void dispatchProgress(long ackedFsn) {
13211321
* Pop every head entry whose tables are all covered by the durable
13221322
* watermarks and call {@link CursorSendEngine#acknowledge} once with
13231323
* the highest popped wireSeq. Trivially-durable entries (tableCount=0,
1324-
* from empty-WAL OK frames or NACK frames) pop unconditionally.
1324+
* from empty-WAL OK frames) pop unconditionally.
13251325
*/
13261326
private void drainPendingDurable() {
13271327
long highest = Long.MIN_VALUE;
@@ -1343,10 +1343,11 @@ private void drainPendingDurable() {
13431343
}
13441344

13451345
/**
1346-
* Stash a wireSeq + per-table seqTxns from the current OK / NACK frame
1347-
* for later durable-ack confirmation. {@link #response} must hold the
1348-
* OK or rejection frame at call time. NACK frames carry no per-table
1349-
* entries, so they enqueue as trivially-durable empty placeholders.
1346+
* Stash a wireSeq + per-table seqTxns from the current OK frame for
1347+
* later durable-ack confirmation. {@link #response} must hold the OK
1348+
* frame at call time. Only the OK path enqueues: rejections never
1349+
* advance the durable watermark -- handleServerRejection either latches
1350+
* a terminal or recycles the connection.
13501351
*/
13511352
private void enqueuePendingOk(long wireSeq) {
13521353
PendingDurableEntry e = acquirePendingEntry();

0 commit comments

Comments
 (0)