dead code removed

Author: jerrinot

core/src/main/java/io/questdb/client/cutlass/qwp/client/MicrobatchBuffer.java

@@ -61,19 +61,14 @@ public class MicrobatchBuffer implements QuietCloseable {
     public static final int STATE_SEALED = 1;
     public static final int STATE_SENDING = 2;
     private static final AtomicLong nextBatchId = new AtomicLong();
-    private final long maxAgeNanos;
-    private final int maxBytes;
     // Flush trigger thresholds
-    private final int maxRows;
     // Batch identification
     private long batchId;
     private int bufferCapacity;
     private int bufferPos;
     // Native memory buffer
     private long bufferPtr;
     private long firstRowTimeNanos;
-    // Symbol tracking for delta encoding
-    private int maxSymbolId = -1;
     // For waiting on recycle (user thread waits for I/O thread to finish)
     private volatile Thread recycleWaiter;
     // Row tracking
@@ -98,9 +93,6 @@ public MicrobatchBuffer(int initialCapacity, int maxRows, int maxBytes, long max
         this.bufferPos = 0;
         this.rowCount = 0;
         this.firstRowTimeNanos = 0;
-        this.maxRows = maxRows;
-        this.maxBytes = maxBytes;
-        this.maxAgeNanos = maxAgeNanos;
         this.batchId = nextBatchId.getAndIncrement();
     }
 
@@ -288,24 +280,6 @@ public void incrementRowCount() {
         rowCount++;
     }
 
-    /**
-     * Checks if the age limit has been exceeded.
-     */
-    public boolean isAgeLimitExceeded() {
-        if (maxAgeNanos <= 0 || rowCount == 0) {
-            return false;
-        }
-        long ageNanos = System.nanoTime() - firstRowTimeNanos;
-        return ageNanos >= maxAgeNanos;
-    }
-
-    /**
-     * Checks if the byte size limit has been exceeded.
-     */
-    public boolean isByteLimitExceeded() {
-        return maxBytes > 0 && bufferPos >= maxBytes;
-    }
-
     /**
      * Returns true if the buffer is in FILLING state (available for writing).
      */
@@ -328,13 +302,6 @@ public boolean isRecycled() {
         return state == STATE_RECYCLED;
     }
 
-    /**
-     * Checks if the row count limit has been exceeded.
-     */
-    public boolean isRowLimitExceeded() {
-        return maxRows > 0 && rowCount >= maxRows;
-    }
-
     /**
      * Returns true if the buffer is in SEALED state (ready to send).
      */
@@ -394,7 +361,6 @@ public void reset() {
         bufferPos = 0;
         rowCount = 0;
         firstRowTimeNanos = 0;
-        maxSymbolId = -1;
         batchId = nextBatchId.getAndIncrement();
         recycleWaiter = null;
         state = STATE_FILLING;
@@ -445,26 +411,6 @@ public void setBufferPos(int pos) {
         this.bufferPos = pos;
     }
 
-    /**
-     * Sets the maximum symbol ID used in this batch.
-     * Used for delta symbol dictionary tracking.
-     */
-    public void setMaxSymbolId(int maxSymbolId) {
-        this.maxSymbolId = maxSymbolId;
-    }
-
-    /**
-     * Checks if the buffer should be flushed based on configured thresholds.
-     *
-     * @return true if any flush threshold is exceeded
-     */
-    public boolean shouldFlush() {
-        if (!hasData()) {
-            return false;
-        }
-        return isRowLimitExceeded() || isByteLimitExceeded() || isAgeLimitExceeded();
-    }
-
     @Override
     public String toString() {
         return "MicrobatchBuffer{" +

core/src/main/java/io/questdb/client/cutlass/qwp/client/QwpWebSocketSender.java

@@ -1116,7 +1116,6 @@ private void flushPendingRows() {
                 activeBuffer.ensureCapacity(messageSize);
                 activeBuffer.write(buffer.getBufferPtr(), messageSize);
                 activeBuffer.incrementRowCount();
-                activeBuffer.setMaxSymbolId(currentBatchMaxSymbolId);
 
                 // Seal and enqueue for sending
                 sealAndSwapBuffer();

core/src/test/java/io/questdb/client/test/cutlass/qwp/client/MicrobatchBufferTest.java

@@ -27,7 +27,9 @@
 import io.questdb.client.cutlass.qwp.client.MicrobatchBuffer;
 import io.questdb.client.std.MemoryTag;
 import io.questdb.client.std.Unsafe;
+
 import static io.questdb.client.test.tools.TestUtils.assertMemoryLeak;
+
 import org.junit.Assert;
 import org.junit.Test;
 
@@ -578,77 +580,6 @@ public void testSetBufferPosOutOfBounds() throws Exception {
         });
     }
 
-    @Test
-    public void testShouldFlushAgeLimit() throws Exception {
-        assertMemoryLeak(() -> {
-            // 50ms timeout
-            try (MicrobatchBuffer buffer = new MicrobatchBuffer(1024, 0, 0, 50_000_000L)) {
-                buffer.writeByte((byte) 1);
-                buffer.incrementRowCount();
-                Assert.assertFalse(buffer.shouldFlush());
-
-                Thread.sleep(60);
-
-                Assert.assertTrue(buffer.shouldFlush());
-                Assert.assertTrue(buffer.isAgeLimitExceeded());
-            }
-        });
-    }
-
-    @Test
-    public void testShouldFlushByteLimit() throws Exception {
-        assertMemoryLeak(() -> {
-            try (MicrobatchBuffer buffer = new MicrobatchBuffer(1024, 0, 10, 0)) {
-                for (int i = 0; i < 9; i++) {
-                    buffer.writeByte((byte) i);
-                    buffer.incrementRowCount();
-                    Assert.assertFalse(buffer.shouldFlush());
-                }
-                buffer.writeByte((byte) 9);
-                buffer.incrementRowCount();
-                Assert.assertTrue(buffer.shouldFlush());
-                Assert.assertTrue(buffer.isByteLimitExceeded());
-            }
-        });
-    }
-
-    @Test
-    public void testShouldFlushEmptyBuffer() throws Exception {
-        assertMemoryLeak(() -> {
-            try (MicrobatchBuffer buffer = new MicrobatchBuffer(1024, 1, 1, 1)) {
-                Assert.assertFalse(buffer.shouldFlush()); // Empty buffer never flushes
-            }
-        });
-    }
-
-    @Test
-    public void testShouldFlushRowLimit() throws Exception {
-        assertMemoryLeak(() -> {
-            try (MicrobatchBuffer buffer = new MicrobatchBuffer(1024, 5, 0, 0)) {
-                for (int i = 0; i < 4; i++) {
-                    buffer.writeByte((byte) i);
-                    buffer.incrementRowCount();
-                    Assert.assertFalse(buffer.shouldFlush());
-                }
-                buffer.writeByte((byte) 4);
-                buffer.incrementRowCount();
-                Assert.assertTrue(buffer.shouldFlush());
-                Assert.assertTrue(buffer.isRowLimitExceeded());
-            }
-        });
-    }
-
-    @Test
-    public void testShouldFlushWithNoThresholds() throws Exception {
-        assertMemoryLeak(() -> {
-            try (MicrobatchBuffer buffer = new MicrobatchBuffer(1024)) {
-                buffer.writeByte((byte) 1);
-                buffer.incrementRowCount();
-                Assert.assertFalse(buffer.shouldFlush()); // No thresholds set
-            }
-        });
-    }
-
     @Test
     public void testStateName() {
         Assert.assertEquals("FILLING", MicrobatchBuffer.stateName(MicrobatchBuffer.STATE_FILLING));