Commit 9674fc5
test(qwp): record JDK-8 verification of the recovery mmap-fault mechanism (#64 M2)
The recovery fix rests on HotSpot delivering a catchable InternalError
(message containing "unsafe memory access operation") at an Unsafe access and
on a direct try/catch catching it. Prior review verified this on JDK 17/21/25
and inferred JDK 8 from the adjacent pre-21 LTS releases, but JDK 8 is the
shipping/CI source of truth and the original flake was on a JDK-8 ZFS runner,
so it had to be checked there directly.
Verified on Temurin 1.8.0_492: MmapSegmentRecoveryFaultTest passes 5/5 in both
-Xint and JIT modes; HotSpot emits "a fault occurred in a recent unsafe memory
access operation in compiled Java code"; a direct try/catch catches the fault
in interpreter, C1, and C2 modes; isMmapAccessFault's shared fragment matches
while the JDK 21+-only needle it replaced does not. The build-jdk8 CI job
already runs this test on JDK 8 on every push, so the gate stays enforced.
Documents the result in the test's class javadoc; no behavior change.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>1 parent 4f78df2 commit 9674fc5
1 file changed
Lines changed: 8 additions & 0 deletions
File tree
- core/src/test/java/io/questdb/client/test/cutlass/qwp/client/sf/cursor
Lines changed: 8 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
66 | 74 | | |
67 | 75 | | |
68 | 76 | | |
| |||
0 commit comments