Commit c35d931
Fix Java 8 build breaks in OIDC device flow
The JDK 8 CI job failed to compile two Java 9+ constructs that a local
JDK 25 build silently accepts (newer rt.jar has the APIs, and -source
without --release does not enforce the Java 8 platform):
- Utf16Sink declared a private interface method, putUnicodeEscape, a
Java 9 feature. Move it to DisplaySafe as a package-private static
helper, putUnicodeEscape(Utf16Sink, int); the two putAsPrintable
overloads now call it. DisplaySafe already owns the display-escaping
policy and shares the package, so the helper stays out of the public
API. The escape logic is moved verbatim.
- OidcDeviceAuth.urlEncode called URLEncoder.encode(String, Charset),
a Java 10 overload. Switch to the Java 8 encode(String, String) form
and catch the (unreachable for UTF-8) UnsupportedEncodingException.
Verified: the three changed files compile under --release 8, the full
core module compiles, and LineSenderExceptionTest,
LineHttpSenderErrorResponseTest, JsonLexerTest and OidcDeviceAuthTest
stay green (156 tests).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent 5dd82b4 commit c35d931
3 files changed
Lines changed: 30 additions & 23 deletions
File tree
- core/src/main/java/io/questdb/client
- cutlass/auth
- std/str
Lines changed: 8 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
| 48 | + | |
48 | 49 | | |
49 | | - | |
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
| |||
885 | 885 | | |
886 | 886 | | |
887 | 887 | | |
888 | | - | |
| 888 | + | |
| 889 | + | |
| 890 | + | |
| 891 | + | |
| 892 | + | |
| 893 | + | |
| 894 | + | |
889 | 895 | | |
890 | 896 | | |
891 | 897 | | |
| |||
Lines changed: 20 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| 27 | + | |
| 28 | + | |
27 | 29 | | |
28 | 30 | | |
29 | 31 | | |
| |||
71 | 73 | | |
72 | 74 | | |
73 | 75 | | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
74 | 94 | | |
Lines changed: 2 additions & 21 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
30 | | - | |
31 | 29 | | |
32 | 30 | | |
33 | 31 | | |
| |||
58 | 56 | | |
59 | 57 | | |
60 | 58 | | |
61 | | - | |
| 59 | + | |
62 | 60 | | |
63 | 61 | | |
64 | 62 | | |
| |||
71 | 69 | | |
72 | 70 | | |
73 | 71 | | |
74 | | - | |
| 72 | + | |
75 | 73 | | |
76 | 74 | | |
77 | 75 | | |
| |||
102 | 100 | | |
103 | 101 | | |
104 | 102 | | |
105 | | - | |
106 | | - | |
107 | | - | |
108 | | - | |
109 | | - | |
110 | | - | |
111 | | - | |
112 | | - | |
113 | | - | |
114 | | - | |
115 | | - | |
116 | | - | |
117 | | - | |
118 | | - | |
119 | | - | |
120 | | - | |
121 | | - | |
122 | 103 | | |
0 commit comments