Commit c783aec
committed
Enable ASM language for zstd huf_decompress_amd64.S
Without enable_language(ASM) in CMakeLists, CMake silently drops the
.S file from the build tree. On x86-64 Linux and macOS the C side of
libzstd still references the symbols exported by the assembly file
(HUF_decompress4X1_usingDTable_internal_fast_asm_loop and its 4X2
sibling), so the final link fails with "Undefined symbols for
architecture x86_64" whenever the host matches ARCH_AMD64 AND NOT
WIN32. Linux x86-64 shows the same failure once the build actually
reaches the link step.
ARM64 and Windows are unaffected because they skip the .S file and
set ZSTD_DISABLE_ASM=1, routing everything through the C fallback.
The asmlib subdirectory's enable_language(ASM_NASM) is separate --
NASM is Intel-syntax and only handles Agner Fog's .asm files.1 parent de85c22 commit c783aec
1 file changed
Lines changed: 6 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
4 | 10 | | |
5 | 11 | | |
6 | 12 | | |
| |||
0 commit comments