Commit d52a9da
committed
fix(config): reject over-int connect_timeout instead of wrapping through (int) cast
Both ws config paths read connect_timeout via view.getLong and cast to
int: connect_timeout=4294967297 silently became a 1 ms timeout, and
2147483648 wrapped to Integer.MIN_VALUE, producing the misleading
'connect_timeout must be > 0: -2147483648'.
- ConfigView.getInt now parses in the long domain: schema range still
reports first (tighter, key-specific), then an over-int value fails
with the actual limit ('connect_timeout must be <= 2147483647: ...')
instead of a generic 'invalid' or a wrapped value.
- Sender.fromConfigWebSocket and QwpQueryClient.fromConfig/validateConfig
read connect_timeout via getInt, aligning with the legacy http/tcp
parseIntValue path that already rejected over-int values.
Covered at ConfigView level (ConfigViewTest) and end-to-end on both
facades (QwpConfigKeysTest.testConnectTimeoutOverIntRejectedOnBoth).1 parent 9d5451c commit d52a9da
5 files changed
Lines changed: 67 additions & 6 deletions
File tree
- core/src
- main/java/io/questdb/client
- cutlass/qwp/client
- impl
- test/java/io/questdb/client/test/impl
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3599 | 3599 | | |
3600 | 3600 | | |
3601 | 3601 | | |
3602 | | - | |
| 3602 | + | |
| 3603 | + | |
| 3604 | + | |
3603 | 3605 | | |
3604 | 3606 | | |
3605 | 3607 | | |
| |||
Lines changed: 6 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
390 | 390 | | |
391 | 391 | | |
392 | 392 | | |
393 | | - | |
| 393 | + | |
| 394 | + | |
| 395 | + | |
394 | 396 | | |
395 | 397 | | |
396 | 398 | | |
| |||
504 | 506 | | |
505 | 507 | | |
506 | 508 | | |
507 | | - | |
| 509 | + | |
| 510 | + | |
| 511 | + | |
508 | 512 | | |
509 | 513 | | |
510 | 514 | | |
| |||
Lines changed: 15 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
178 | 178 | | |
179 | 179 | | |
180 | 180 | | |
181 | | - | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
182 | 186 | | |
183 | | - | |
| 187 | + | |
184 | 188 | | |
185 | 189 | | |
186 | 190 | | |
187 | 191 | | |
| 192 | + | |
| 193 | + | |
188 | 194 | | |
189 | 195 | | |
190 | 196 | | |
191 | | - | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
192 | 204 | | |
193 | 205 | | |
194 | 206 | | |
| |||
Lines changed: 23 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
115 | 115 | | |
116 | 116 | | |
117 | 117 | | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
118 | 141 | | |
119 | 142 | | |
120 | 143 | | |
| |||
Lines changed: 20 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
57 | 77 | | |
58 | 78 | | |
59 | 79 | | |
| |||
0 commit comments