Skip to content

Commit db44da8

Browse files
committed
ci: also build javadoc on the JDK 25 job
Extend the JDK 25 smoke to build the javadoc jar (mvn -P javadoc package, no tests) in addition to compiling main + test sources, so javadoc is covered on both JDK 8 and JDK 25.
1 parent 2a279cd commit db44da8

1 file changed

Lines changed: 7 additions & 6 deletions

File tree

.github/workflows/ci.yml

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,12 @@ jobs:
4040
run: mvn -B -ntp -P javadoc clean install
4141

4242
# The client is also consumed as a submodule of the main questdb repo, which
43-
# builds on JDK 25. Guard against JDK 25 compile breakage here (main + test
44-
# sources, both modules), but do NOT run the tests -- the parent repo runs
45-
# them against a real server.
43+
# builds on JDK 25. Guard against JDK 25 compile breakage (main + test
44+
# sources, both modules) and confirm the javadoc jar builds on JDK 25 too
45+
# (-P javadoc attaches it at the package phase). Do NOT run the tests -- the
46+
# parent repo runs them against a real server.
4647
compile-jdk25:
47-
name: Compile smoke (JDK 25)
48+
name: Compile & javadoc smoke (JDK 25)
4849
runs-on: ubuntu-latest
4950
timeout-minutes: 20
5051
steps:
@@ -58,5 +59,5 @@ jobs:
5859
java-version: "25"
5960
cache: maven
6061

61-
- name: Compile main and test sources (no tests run)
62-
run: mvn -B -ntp -DskipTests clean test-compile
62+
- name: Compile (main + test) and build javadoc (no tests run)
63+
run: mvn -B -ntp -P javadoc -DskipTests clean package

0 commit comments

Comments
 (0)