Skip to content

refactor(qwp)!: rename sf_max_bytes to sf_max_segment_bytes#79

Open
mtopolnik wants to merge 1 commit into
mainfrom
mt_sf-max-segment-bytes
Open

refactor(qwp)!: rename sf_max_bytes to sf_max_segment_bytes#79
mtopolnik wants to merge 1 commit into
mainfrom
mt_sf-max-segment-bytes

Conversation

@mtopolnik

Copy link
Copy Markdown

Renames the store-and-forward connect-string key sf_max_bytes to sf_max_segment_bytes: the key caps a single SF segment, and the new name says so; it also pairs cleanly with sf_max_total_bytes. The public snake_case property SenderOptions.sf_max_bytes follows the key (nameof propagates the parse and UDP-reject sites); the WebSocketOnlyKeys array and QwpConnectStringKeys.IngressOnly literal key lists are renamed by hand so the WS-only guard and ToString() round-trip skip keep applying.

Breaking for 4.0.0-beta.1 consumers — accepted; beta compatibility is by policy not maintained, so this is a hard rename with no alias.

Part of the cross-repo rename of this key, matching questdb/java-questdb-client#70.

Not validated locally (no dotnet SDK on the machine that produced this) — CI must validate.

🤖 Generated with Claude Code

The connect-string key caps a single SF segment, and the new name says
so; it also pairs cleanly with sf_max_total_bytes. The public
SenderOptions property follows the key, and the WebSocket-only key
list, QWP key table, error messages, tests, and README rename in step
so the old spelling is gone entirely.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@mtopolnik, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a2d105f1-45d3-4998-a1ae-ce578b38a14e

📥 Commits

Reviewing files that changed from the base of the PR and between d0162aa and 646c00d.

📒 Files selected for processing (8)
  • README.md
  • src/net-questdb-client-tests/QuestDbDockerIngestFaultToleranceTests.cs
  • src/net-questdb-client-tests/Qwp/QwpWebSocketSenderTests.cs
  • src/net-questdb-client-tests/SenderOptionsTests.cs
  • src/net-questdb-client/Qwp/QwpConnectStringKeys.cs
  • src/net-questdb-client/Qwp/Sf/QwpSegmentRing.cs
  • src/net-questdb-client/Senders/QwpWebSocketSender.cs
  • src/net-questdb-client/Utils/SenderOptions.cs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch mt_sf-max-segment-bytes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant