refactor(qwp)!: rename sf_max_bytes to sf_max_segment_bytes#79
refactor(qwp)!: rename sf_max_bytes to sf_max_segment_bytes#79mtopolnik wants to merge 1 commit into
Conversation
The connect-string key caps a single SF segment, and the new name says so; it also pairs cleanly with sf_max_total_bytes. The public SenderOptions property follows the key, and the WebSocket-only key list, QWP key table, error messages, tests, and README rename in step so the old spelling is gone entirely. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 59 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Renames the store-and-forward connect-string key
sf_max_bytestosf_max_segment_bytes: the key caps a single SF segment, and the new name says so; it also pairs cleanly withsf_max_total_bytes. The public snake_case propertySenderOptions.sf_max_bytesfollows the key (nameofpropagates the parse and UDP-reject sites); theWebSocketOnlyKeysarray andQwpConnectStringKeys.IngressOnlyliteral key lists are renamed by hand so the WS-only guard andToString()round-trip skip keep applying.Breaking for 4.0.0-beta.1 consumers — accepted; beta compatibility is by policy not maintained, so this is a hard rename with no alias.
Part of the cross-repo rename of this key, matching questdb/java-questdb-client#70.
Not validated locally (no dotnet SDK on the machine that produced this) — CI must validate.
🤖 Generated with Claude Code