legacy_http -> stdlib_http

Author: glasstiger

src/options.ts

@@ -160,7 +160,7 @@ class SenderOptions {
   log?: Logger;
   agent?: Agent | http.Agent | https.Agent;
 
-  legacy_http?: boolean;
+  stdlib_http?: boolean;
 
   auth?: {
     username?: string;
@@ -286,7 +286,7 @@ function parseConfigurationString(
   parseTlsOptions(options);
   parseRequestTimeoutOptions(options);
   parseMaxNameLength(options);
-  parseLegacyTransport(options);
+  parseStdlibTransport(options);
 }
 
 function parseSettings(
@@ -348,8 +348,8 @@ const ValidConfigKeys = [
   "init_buf_size",
   "max_buf_size",
   "max_name_len",
+  "stdlib_http",
   "tls_verify",
-  "legacy_http",
   "tls_ca",
   "tls_roots",
   "tls_roots_password",
@@ -472,8 +472,8 @@ function parseMaxNameLength(options: SenderOptions) {
   parseInteger(options, "max_name_len", "max name length", 1);
 }
 
-function parseLegacyTransport(options: SenderOptions) {
-  parseBoolean(options, "legacy_http", "legacy http");
+function parseStdlibTransport(options: SenderOptions) {
+  parseBoolean(options, "stdlib_http", "stdlib http");
 }
 
 function parseBoolean(

src/transport/http/base.ts

@@ -116,8 +116,7 @@ abstract class HttpTransportBase implements SenderTransport {
    * HTTP transport does not require explicit connection closure.
    * @returns Promise that resolves immediately
    */
-  async close(): Promise<void> {
-  }
+  async close(): Promise<void> {}
 
   /**
    * Gets the default auto-flush row count for HTTP transport.

src/transport/http/legacy.ts src/transport/http/stdlib.tssrc/transport/http/legacy.ts renamed to src/transport/http/stdlib.ts

@@ -4,7 +4,7 @@ import { Buffer } from "node:buffer";
 import { SenderOptions, HTTP, HTTPS, TCP, TCPS } from "../options";
 import { UndiciTransport } from "./http/undici";
 import { TcpTransport } from "./tcp";
-import { HttpTransport } from "./http/legacy";
+import { HttpTransport } from "./http/stdlib";
 
 /**
  * Interface for QuestDB transport implementations. <br>
@@ -56,7 +56,7 @@ function createTransport(options: SenderOptions): SenderTransport {
   switch (options.protocol) {
     case HTTP:
     case HTTPS:
-      return options.legacy_http
+      return options.stdlib_http
         ? new HttpTransport(options)
         : new UndiciTransport(options);
     case TCP:

src/transport/index.ts

@@ -7,7 +7,7 @@ import http from "http";
 import { Sender } from "../src";
 import { SenderOptions } from "../src/options";
 import { UndiciTransport } from "../src/transport/http/undici";
-import { HttpTransport } from "../src/transport/http/legacy";
+import { HttpTransport } from "../src/transport/http/stdlib";
 import { MockProxy } from "./util/mockproxy";
 import { MockHttp } from "./util/mockhttp";
 
@@ -278,12 +278,12 @@ describe("Sender HTTP suite", function () {
     await agent.destroy();
   });
 
-  it("supports custom legacy HTTP agent", async function () {
+  it("supports custom stdlib HTTP agent", async function () {
     mockHttp.reset();
     const agent = new http.Agent({ maxSockets: 128 });
 
     const sender = Sender.fromConfig(
-      `http::addr=${PROXY_HOST}:${MOCK_HTTP_PORT};legacy_http=on`,
+      `http::addr=${PROXY_HOST}:${MOCK_HTTP_PORT};stdlib_http=on`,
       { agent: agent },
     );
     await sendData(sender);