more type fixes

Author: glasstiger

src/options.ts

@@ -180,7 +180,7 @@ class SenderOptions {
    * - 'agent' is a custom http/https agent used by the <a href="Sender.html">Sender</a> when http/https transport is used. <br>
    * A <i>http.Agent</i> or <i>https.Agent</i> object is expected.
    */
-  constructor(configurationString: string, extraOptions: ExtraOptions = undefined) {
+  constructor(configurationString: string, extraOptions?: ExtraOptions) {
     parseConfigurationString(this, configurationString);
 
     if (extraOptions) {
@@ -231,7 +231,7 @@ class SenderOptions {
    *
    * @return {SenderOptions} A Sender configuration object initialized from the provided configuration string.
    */
-  static fromConfig(configurationString: string, extraOptions: ExtraOptions = undefined): SenderOptions {
+  static fromConfig(configurationString: string, extraOptions?: ExtraOptions): SenderOptions {
     return new SenderOptions(configurationString, extraOptions);
   }
 
@@ -246,7 +246,7 @@ class SenderOptions {
    *
    * @return {SenderOptions} A Sender configuration object initialized from the <b>QDB_CLIENT_CONF</b> environment variable.
    */
-  static fromEnv(extraOptions: ExtraOptions = undefined): SenderOptions {
+  static fromEnv(extraOptions?: ExtraOptions): SenderOptions {
     return SenderOptions.fromConfig(process.env.QDB_CLIENT_CONF, extraOptions);
   }
 }

src/sender.ts

@@ -128,7 +128,7 @@ class Sender {
    *
    * @return {Sender} A Sender object initialized from the provided configuration string.
    */
-  static fromConfig(configurationString: string, extraOptions: ExtraOptions = undefined): Sender {
+  static fromConfig(configurationString: string, extraOptions?: ExtraOptions): Sender {
     return new Sender(
       SenderOptions.fromConfig(configurationString, extraOptions),
     );
@@ -145,7 +145,7 @@ class Sender {
    *
    * @return {Sender} A Sender object initialized from the <b>QDB_CLIENT_CONF</b> environment variable.
    */
-  static fromEnv(extraOptions: ExtraOptions = undefined): Sender {
+  static fromEnv(extraOptions?: ExtraOptions): Sender {
     return new Sender(
       SenderOptions.fromConfig(process.env.QDB_CLIENT_CONF, extraOptions),
     );
@@ -488,12 +488,12 @@ class Sender {
       name: string,
       value: unknown,
       writeValue: () => void,
-      valueType?: string | null,
+      valueType?: string
   ) {
     if (typeof name !== "string") {
       throw new Error(`Column name must be a string, received ${typeof name}`);
     }
-    if (valueType != null && typeof value !== valueType) {
+    if (valueType && typeof value !== valueType) {
       throw new Error(
           `Column value must be of type ${valueType}, received ${typeof value}`,
       );

test/sender.integration.test.ts

@@ -1,6 +1,6 @@
 // @ts-check
 import { describe, it, expect, beforeAll, afterAll } from "vitest";
-import { GenericContainer } from "testcontainers";
+import { GenericContainer, StartedTestContainer } from "testcontainers";
 import http from "http";
 
 import { Sender } from "../src";
@@ -15,9 +15,9 @@ async function sleep(ms: number) {
 }
 
 describe("Sender tests with containerized QuestDB instance", () => {
-  let container: any;
+  let container: StartedTestContainer;
 
-  async function query(container: any, query: string) {
+  async function query(container: StartedTestContainer, query: string) {
     const options: http.RequestOptions = {
       hostname: container.getHost(),
       port: container.getMappedPort(QUESTDB_HTTP_PORT),
@@ -46,7 +46,7 @@ describe("Sender tests with containerized QuestDB instance", () => {
     });
   }
 
-  async function runSelect(container: any, select: string, expectedCount: number, timeout = 60000) {
+  async function runSelect(container: StartedTestContainer, select: string, expectedCount: number, timeout = 60000) {
     const interval = 500;
     const num = timeout / interval;
     let selectResult: any;
@@ -62,7 +62,7 @@ describe("Sender tests with containerized QuestDB instance", () => {
     );
   }
 
-  async function waitForTable(container: any, tableName: string, timeout = 30000) {
+  async function waitForTable(container: StartedTestContainer, tableName: string, timeout = 30000) {
     await runSelect(container, `tables() where table_name='${tableName}'`, 1, timeout);
   }
 

test/util/proxy.ts

@@ -22,7 +22,7 @@ class Proxy {
       console.info("remote connection closed");
     });
 
-    this.remote.on("error", (err: unknown) => {
+    this.remote.on("error", (err: Error) => {
       console.error(`remote connection: ${err}`);
     });
   }