Skip to content

chore(nodejs): refactor buffer handling#47

Merged
glasstiger merged 1 commit into
mainfrom
refactor_buffer_handling
Jul 10, 2025
Merged

chore(nodejs): refactor buffer handling#47
glasstiger merged 1 commit into
mainfrom
refactor_buffer_handling

Conversation

@glasstiger
Copy link
Copy Markdown
Collaborator

Refactor buffer handling to look more like it was before PR #42

  • when flush() is called, the buffer gets compacted right after a copy is made for sending
  • deprecating the copy_buffer option, we always create a copy of the sender's buffer for sending, even if calls to the sender are fully sequential
  • since all async sending tasks are working on their own buffer, we can remove promise chaining

@puzpuzpuz puzpuzpuz self-requested a review July 10, 2025 10:06
Comment thread src/sender.ts
@glasstiger glasstiger merged commit a1915db into main Jul 10, 2025
4 checks passed
@glasstiger glasstiger deleted the refactor_buffer_handling branch July 17, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants