feat(ui): make SSO re-authentication optional on logout#412
Merged
Conversation
Collaborator
|
Hi @glasstiger, I think having
I think we can resolve this issue by storing the SSO user name alongside with SSO information, and having two states:
WDYT? |
Contributor
Author
Yes, UX would have needed more work for sure. I have merged your changes from #416 into this PR now. |
emrberk
approved these changes
Apr 29, 2025
Vaibhav91one
pushed a commit
to Vaibhav91one/ui
that referenced
this pull request
Oct 28, 2025
* feat(ui): make SSO re-authentication optional on logout * do not clear error count on login attempt * update submodule * update submodule * Continue as <username> button
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Currently the web console forces the user to re-authenticate with the OAuth2/OIDC provider after logout by sending the query param
prompt=loginon the authorization code request.Logout can be initiated in a number of ways:
In most cases the user has a valid session with the OAuth2/OIDC provider, which means that the provider is able to issue an authorization code without the need for the user typing their password in again.
Therefore the query param
prompt=loginshould be optional on logout, and should be sent only when required.This includes scenarios when:
stateparameter does not match or missingHowever, in scenarios when the user would logout only to switch to a database user, such as built-in admin, do something, and change back to their SSO user, we should not send
prompt=login.Now the Login screen will give the option to the user to continue with the currently logged in OAuth2 user, or switch to a different account.