refactor: remove redundant return types

Removed redundant return types from methods in QueueItEngine and
QueueITWaitingRoomProvider classes. This change simplifies the code
by eliminating unnecessary return statements.

Author: alexanderthoren

Sources/QueueITLib/NewConnection.swift

@@ -10,7 +10,7 @@ final class Connection: QueueITApiClient {
         expectedStatus: Int,
         success: @escaping QueueServiceSuccess,
         failure: @escaping QueueServiceFailure
-    ) -> String {
+    ) {
         var request = URLRequest(url: url)
         request.httpMethod = httpMethod
 
@@ -19,7 +19,7 @@ final class Connection: QueueITApiClient {
             request.httpBody = jsonData
         } catch {
             failure(error, "Failed to serialize request body.")
-            return ""
+            return
         }
 
         request.addValue("application/json", forHTTPHeaderField: "Accept")
@@ -32,8 +32,6 @@ final class Connection: QueueITApiClient {
             failure: failure,
             delegate: self
         )
-
-        return connectionRequest?.uniqueIdentifier ?? ""
     }
 }
 

Sources/QueueITLib/NewQueueITApiClient.swift

@@ -32,7 +32,7 @@ class QueueITApiClient {
         enqueueKey: String?,
         success: @escaping (QueueStatus?) -> Void,
         failure: @escaping QueueServiceFailure
-    ) -> String {
+    ) {
         var bodyDict: [String: Any] = [
             "userId": userId,
             "userAgent": userAgent,
@@ -61,7 +61,7 @@ class QueueITApiClient {
         urlAsString += "/\(eventOrAliasId)"
         urlAsString += "/enqueue"
 
-        return submitPOSTPath(
+        submitPOSTPath(
             path: urlAsString,
             body: bodyDict,
             success: { data in
@@ -88,18 +88,18 @@ class QueueITApiClient {
         body bodyDict: [String: Any],
         success: @escaping QueueServiceSuccess,
         failure: @escaping QueueServiceFailure
-    ) -> String {
+    ) {
         guard let url = URL(string: path) else {
             let error = NSError(
                 domain: "QueueITApiClient",
                 code: -1,
                 userInfo: [NSLocalizedDescriptionKey: "Invalid URL"]
             )
             failure(error, "Invalid URL")
-            return ""
+            return
         }
 
-        return submitRequest(
+        submitRequest(
             with: url,
             method: "POST",
             body: bodyDict,
@@ -116,7 +116,7 @@ class QueueITApiClient {
         expectedStatus _: Int,
         success _: @escaping QueueServiceSuccess,
         failure _: @escaping QueueServiceFailure
-    ) -> String {
-        return ""
+    ) {
+        return
     }
 }

Sources/QueueITLib/NewQueueITEngine.swift

@@ -78,16 +78,16 @@ public final class QueueItEngine {
         return waitingRoomProvider.isRequestInProgress()
     }
 
-    public func run(withEnqueueKey enqueueKey: String) throws -> Bool {
-        return try waitingRoomProvider.tryPassWithEnqueueKey(enqueueKey)
+    public func run(withEnqueueKey enqueueKey: String) throws {
+        try waitingRoomProvider.tryPassWithEnqueueKey(enqueueKey)
     }
 
-    public func run(withEnqueueToken enqueueToken: String) throws -> Bool {
-        return try waitingRoomProvider.tryPassWithEnqueueToken(enqueueToken)
+    public func run(withEnqueueToken enqueueToken: String) throws {
+        try waitingRoomProvider.tryPassWithEnqueueToken(enqueueToken)
     }
 
-    public func run() throws -> Bool {
-        return try waitingRoomProvider.tryPass()
+    public func run() throws {
+        try waitingRoomProvider.tryPass()
     }
 
     public func showQueue(queueUrl: String, targetUrl: String) {

Sources/QueueITLib/NewQueueITWaitingRoomProvider.swift

@@ -38,16 +38,16 @@ final class QueueITWaitingRoomProvider {
         internetReachability = QueueITReachability.reachabilityForInternetConnection()
     }
 
-    func tryPass() throws -> Bool {
-        return try tryEnqueue(enqueueToken: nil, enqueueKey: nil)
+    func tryPass() throws {
+        try tryEnqueue(enqueueToken: nil, enqueueKey: nil)
     }
 
-    func tryPassWithEnqueueToken(_ enqueueToken: String?) throws -> Bool {
-        return try tryEnqueue(enqueueToken: enqueueToken, enqueueKey: nil)
+    func tryPassWithEnqueueToken(_ enqueueToken: String?) throws {
+        try tryEnqueue(enqueueToken: enqueueToken, enqueueKey: nil)
     }
 
-    func tryPassWithEnqueueKey(_ enqueueKey: String?) throws -> Bool {
-        return try tryEnqueue(enqueueToken: nil, enqueueKey: enqueueKey)
+    func tryPassWithEnqueueKey(_ enqueueKey: String?) throws {
+        try tryEnqueue(enqueueToken: nil, enqueueKey: enqueueKey)
     }
 
     func isRequestInProgress() -> Bool {
@@ -56,7 +56,7 @@ final class QueueITWaitingRoomProvider {
 }
 
 private extension QueueITWaitingRoomProvider {
-    func tryEnqueue(enqueueToken: String?, enqueueKey: String?) throws -> Bool {
+    func tryEnqueue(enqueueToken: String?, enqueueKey: String?) throws {
         guard checkConnection() else {
             throw NSError(
                 domain: "QueueITRuntimeException",
@@ -93,7 +93,6 @@ private extension QueueITWaitingRoomProvider {
                 )
             }
         }
-        return true
     }
 
     func tryEnqueueWithUserAgent(secretAgent: String, enqueueToken: String?, enqueueKey: String?) throws {