fix: relax PATH_CHALLENGE validation#460
Open
larseggert wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@marten-seemann should I rebase? (I'll only do the work if you take the PR...) |
The previous check required every PATH_CHALLENGE to have a matching PATH_RESPONSE, which was too strict because: - Some PATH_CHALLENGE frames may be lost in transit - The server may send multiple challenges for redundancy (per RFC 9000 §8.2) - On the final path, the peer may close the connection successfully without responding to a late-arriving PATH_CHALLENGE Also add Python 3.14 support, because it was missing.
larseggert
force-pushed
the
fix-path-validation
branch
from
1f75419 to
2ac05ad
Compare
Collaborator
|
Yes please do. I just need to carefully review the logic. |
Contributor
Author
|
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous check required every PATH_CHALLENGE to have a matching PATH_RESPONSE, which was too strict because:
Also add Python 3.14 support, because it was missing.
Note
Relax PATH_CHALLENGE validation in
TestCasePortRebinding.transferand add asyncio child-watcher shims in trace.py to support Python 3.14+Switch to per-path tracking of
PATH_CHALLENGEvalues and require at least one matchingPATH_RESPONSEper non-final path in testcases_quic.py; add event-loop initialization and child-watcher shims before importingpysharkin trace.py.📍Where to Start
Start with the revised validation in
TestCasePortRebinding.transferin testcases_quic.py, then review the asyncio initialization and watcher shims in trace.py.Macroscope summarized 2ac05ad.