Generate header related methods in Message class.#14
Merged
Conversation
Member
|
@the-thing great, thanks for pursuing this. |
Message class.
Member
|
I'll need to build a release once this is merged so you can continue with this on quickfix-j/quickfixj#1048 . I'll keep you posted. |
Contributor
Author
|
No rush. I will not be able to continue since this is the only thing left. I mean once this is merged and released I will have to update the dependency as part of quickfix-j/quickfixj#1048 and I will modify a test case to include class names for FIXT and FIX latest. I believe this is the only thing left. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
newHeader()andgetHeader()methods will be generated in the Message class. This will help keeping consitent header behavior across all fix versions.See
quickfix.Message#getHeadersubclasses to returnHeaderwith respective FIX version header quickfixj#1048The new classes will look like this.