Skip to content

fix: resolve duplicate #validation anchor in configuration.mdx#58

Merged
chrjohn merged 5 commits into
mainfrom
copilot/re-add-lost-change
May 14, 2026
Merged

fix: resolve duplicate #validation anchor in configuration.mdx#58
chrjohn merged 5 commits into
mainfrom
copilot/re-add-lost-change

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 14, 2026

The ### Validation heading in docs/configuration.mdx produced a #validation anchor that conflicted with the ## Validation heading in the imported _configuration_reference.mdx pulled in at build time.

Changes

  • docs/configuration.mdx: renamed ### Validation### Basic Validation to eliminate the anchor conflict
  • Removed the now-unnecessary <a id="validation-subset"></a> workaround anchor tag
  • Added a link from the Basic Validation section to the full Validation section in the imported configuration reference below
  • .gitignore: updated to exclude docs/_configuration_reference.mdx (the fetched reference file extension had changed from .md to .mdx, causing it to slip through the ignore rule)

@chrjohn
Copy link
Copy Markdown
Member

chrjohn commented May 14, 2026

@copilot well, that doesn't look too good. Build is falling...

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 14, 2026

@copilot well, that doesn't look too good. Build is falling...

Sorry about that. The {#validation-subset} heading ID syntax is Markdown-only — in .mdx files, {...} is parsed as a JSX expression, which caused the acorn parse error. The <a id="validation-subset"></a> tag is actually the correct way to declare a custom anchor in MDX, so it can't be removed. Reverted in 1bd9a6e.

Copilot AI requested a review from chrjohn May 14, 2026 07:44
@chrjohn
Copy link
Copy Markdown
Member

chrjohn commented May 14, 2026

@copilot but that causes a conflict with the validation section from the imported configuration doc.
Please rename the whole section to basic validation then and add a link to the complete validation section which is in the imported configuration doc.

Copilot AI and others added 2 commits May 14, 2026 07:56
… link to full reference

Agent-Logs-Url: https://github.com/quickfix-j/quickfixj-pages/sessions/e414c5c9-930b-40d5-abb0-1552521fac26

Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
…sion changed from .md)

Agent-Logs-Url: https://github.com/quickfix-j/quickfixj-pages/sessions/e414c5c9-930b-40d5-abb0-1552521fac26

Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 14, 2026

@copilot but that causes a conflict with the validation section from the imported configuration doc.
Please rename the whole section to basic validation then and add a link to the complete validati...

Done in a8b4e8c. Renamed ### Validation### Basic Validation (resolves the anchor conflict with ## Validation from the imported reference doc) and added a link: "For the complete list of validation settings, see Validation in the Full Configuration Options reference below." Also removed the <a id="validation-subset"></a> workaround tag that's no longer needed, and updated .gitignore to exclude the fetched _configuration_reference.mdx file (c0e6de7).

Copilot AI changed the title fix: restore {#validation-subset} heading ID and drop redundant anchor tag fix: resolve duplicate #validation anchor in configuration.mdx May 14, 2026
@chrjohn chrjohn merged commit 5c72f38 into main May 14, 2026
2 checks passed
@chrjohn chrjohn deleted the copilot/re-add-lost-change branch May 14, 2026 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants