Skip to content

Commit 180fbd4

Browse files
committed
QFJ-961 Constructors for UtcDate/Time fields should return date in UTC (#214)
* QFJ-961 Constructors for UtcDate/Time fields should return date in UTC - added ZoneOffset.UTC
1 parent 92fc68a commit 180fbd4

5 files changed

Lines changed: 13 additions & 8 deletions

File tree

quickfixj-core/src/main/java/quickfix/UtcDateField.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,15 @@
2020
package quickfix;
2121

2222
import java.time.LocalDate;
23+
import java.time.ZoneOffset;
2324

2425
/**
2526
* A LocalDate-valued message field with up to nanosecond precision.
2627
*/
2728
public class UtcDateField extends Field<LocalDate> {
2829

2930
protected UtcDateField(int field) {
30-
super(field, LocalDate.now());
31+
super(field, LocalDate.now(ZoneOffset.UTC));
3132
}
3233

3334
protected UtcDateField(int field, LocalDate data) {

quickfixj-core/src/main/java/quickfix/UtcDateOnlyField.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,15 @@
2020
package quickfix;
2121

2222
import java.time.LocalDate;
23+
import java.time.ZoneOffset;
2324

2425
/**
2526
* A date-valued message field.
2627
*/
2728
public class UtcDateOnlyField extends Field<LocalDate> {
2829

2930
public UtcDateOnlyField(int field) {
30-
super(field, LocalDate.now());
31+
super(field, LocalDate.now(ZoneOffset.UTC));
3132
}
3233

3334
protected UtcDateOnlyField(int field, LocalDate data) {

quickfixj-core/src/main/java/quickfix/UtcTimeField.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
package quickfix;
2121

2222
import java.time.LocalTime;
23+
import java.time.ZoneOffset;
2324

2425
/**
2526
* A LocalTime-valued message field with up to nanosecond precision.
@@ -29,7 +30,7 @@ public class UtcTimeField extends Field<LocalTime> {
2930
protected UtcTimestampPrecision precision = UtcTimestampPrecision.MILLIS;
3031

3132
protected UtcTimeField(int field) {
32-
super(field, LocalTime.now());
33+
super(field, LocalTime.now(ZoneOffset.UTC));
3334
}
3435

3536
protected UtcTimeField(int field, LocalTime data) {

quickfixj-core/src/main/java/quickfix/UtcTimeOnlyField.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
package quickfix;
2121

2222
import java.time.LocalTime;
23+
import java.time.ZoneOffset;
2324

2425
/*
2526
* A time-valued message field.
@@ -29,7 +30,7 @@ public class UtcTimeOnlyField extends Field<LocalTime> {
2930
private UtcTimestampPrecision precision = UtcTimestampPrecision.MILLIS;
3031

3132
public UtcTimeOnlyField(int field) {
32-
super(field, LocalTime.now());
33+
super(field, LocalTime.now(ZoneOffset.UTC));
3334
}
3435

3536
protected UtcTimeOnlyField(int field, LocalTime data) {
@@ -42,7 +43,7 @@ protected UtcTimeOnlyField(int field, LocalTime data, UtcTimestampPrecision prec
4243
}
4344

4445
public UtcTimeOnlyField(int field, boolean includeMilliseconds) {
45-
super(field, LocalTime.now());
46+
super(field, LocalTime.now(ZoneOffset.UTC));
4647
this.precision = includeMilliseconds ? UtcTimestampPrecision.MILLIS : UtcTimestampPrecision.SECONDS;
4748
}
4849

quickfixj-core/src/main/java/quickfix/UtcTimeStampField.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
package quickfix;
2121

2222
import java.time.LocalDateTime;
23+
import java.time.ZoneOffset;
2324

2425
/**
2526
* A timestamp-valued message field (a timestamp has both a date and a time).
@@ -29,7 +30,7 @@ public class UtcTimeStampField extends Field<LocalDateTime> {
2930
private UtcTimestampPrecision precision = UtcTimestampPrecision.MILLIS;
3031

3132
public UtcTimeStampField(int field) {
32-
super(field, LocalDateTime.now());
33+
super(field, LocalDateTime.now(ZoneOffset.UTC));
3334
}
3435

3536
protected UtcTimeStampField(int field, LocalDateTime data) {
@@ -42,12 +43,12 @@ protected UtcTimeStampField(int field, LocalDateTime data, UtcTimestampPrecision
4243
}
4344

4445
public UtcTimeStampField(int field, boolean includeMilliseconds) {
45-
super(field, LocalDateTime.now());
46+
super(field, LocalDateTime.now(ZoneOffset.UTC));
4647
this.precision = includeMilliseconds ? UtcTimestampPrecision.MILLIS : UtcTimestampPrecision.SECONDS;
4748
}
4849

4950
public UtcTimeStampField(int field, UtcTimestampPrecision precision) {
50-
super(field, LocalDateTime.now());
51+
super(field, LocalDateTime.now(ZoneOffset.UTC));
5152
this.precision = precision;
5253
}
5354

0 commit comments

Comments
 (0)