Skip to content

Remove unnecessary IoSession.close() for session that is already closed #1056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrjohn merged 1 commit into from
Oct 4, 2025
+1 −2
Merged

Remove unnecessary IoSession.close() for session that is already closed #1056

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion quickfixj-core/src/main/java/quickfix/mina/AbstractIoHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,6 @@ public void sessionClosed(IoSession ioSession) {
throw e;
} finally {
ioSession.removeAttribute(SessionConnector.QF_SESSION);
ioSession.closeOnFlush();
}
}

Expand Down
2 changes: 1 addition & 1 deletion quickfixj-core/src/main/java/quickfix/mina/initiator/InitiatorProxyIoHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public void sessionCreated(IoSession session) throws Exception {
}

@Override
public void sessionClosed(IoSession ioSession) throws Exception {
public void sessionClosed(IoSession ioSession) {
this.initiatorIoHandler.sessionClosed(ioSession);
}

Expand Down