Skip to content

Static inner classes, autoboxing changes, typos#1057

Merged
chrjohn merged 7 commits into
quickfix-j:masterfrom
abhishekraha:improvements
Apr 14, 2026
Merged

Static inner classes, autoboxing changes, typos#1057
chrjohn merged 7 commits into
quickfix-j:masterfrom
abhishekraha:improvements

Conversation

@abhishekraha

@abhishekraha abhishekraha commented Oct 3, 2025

Copy link
Copy Markdown
Contributor

Changes :

  1. Refactored code to remove unwanted object creation
  2. Changed inner class to be static to avoid mem leakage
  3. IntelliJ remove/regroup-imports and indentation
  4. grammatical fixes

Comment thread quickfixj-core/src/main/java/quickfix/DefaultSessionFactory.java
Comment thread quickfixj-core/src/main/java/quickfix/FileLog.java
Comment thread quickfixj-core/src/main/java/quickfix/MessageCracker.java
Comment thread quickfixj-core/src/main/java/quickfix/MessageCracker.java
Comment thread quickfixj-core/src/main/java/quickfix/SleepycatStore.java

@chrjohn chrjohn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please roll back the import changes.

@abhishekraha

Copy link
Copy Markdown
Contributor Author

Please roll back the import changes.

done.

out of curiosity - is the intention that we only import the classes that are required and not the whole package because importing is a compile time task and I don't think it has any latency implications.

@abhishekraha abhishekraha requested a review from chrjohn October 4, 2025 17:07
@chrjohn

chrjohn commented Oct 5, 2025

Copy link
Copy Markdown
Member

out of curiosity - is the intention that we only import the classes that are required and not the whole package because importing is a compile time task and I don't think it has any latency implications.

The intention is simply that one uses IntelliJ, another uses Eclipse, a third Netbeans and either has its own taste of how imports should be organized (unless you configure it the same for all IDEs).

@abhishekraha

Copy link
Copy Markdown
Contributor Author

out of curiosity - is the intention that we only import the classes that are required and not the whole package because importing is a compile time task and I don't think it has any latency implications.

The intention is simply that one uses IntelliJ, another uses Eclipse, a third Netbeans and either has its own taste of how imports should be organized (unless you configure it the same for all IDEs).

Got it. Thanks

I've reverted the import changes.

I didn't get much time after this initial one where my changes were around non-critical execution path which were called once maybe twice in the life cycle
I'll probably try to contribute to things that are more important in my next PR

@chrjohn

chrjohn commented Oct 29, 2025

Copy link
Copy Markdown
Member

@abhishekraha thanks for your PR! 👍

Comment thread quickfixj-core/src/main/java/quickfix/mina/acceptor/AbstractSocketAcceptor.java Outdated
@chrjohn chrjohn added this to the QFJ 3.0.1 milestone Apr 14, 2026
@chrjohn chrjohn changed the title Improvements Static inner classes, autoboxing changes, typos Apr 14, 2026
@chrjohn chrjohn merged commit 34a588f into quickfix-j:master Apr 14, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants