Skip to content

Make DataDictionaryTest external DTD error assertion locale-independent #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrjohn merged 1 commit into from
Dec 11, 2025
Merged

Make DataDictionaryTest external DTD error assertion locale-independent #1091

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions quickfixj-base/src/test/java/quickfix/DataDictionaryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
import java.io.ByteArrayInputStream;
import java.net.URL;
import java.net.URLClassLoader;
import java.util.Locale;

import javax.xml.parsers.DocumentBuilderFactory;

Expand Down Expand Up @@ -677,11 +678,17 @@ public void shouldLoadDictionaryWhenExternalDTDisEnabled() throws ConfigError {

@Test
public void shouldFailToLoadDictionaryWhenExternalDTDisDisabled() {
Locale originalLocale = Locale.getDefault();
Locale.setDefault(Locale.US);
try {
new DataDictionary("FIX_External_DTD.xml");
fail("should fail to load dictionary with external DTD");
} catch (ConfigError e) {
assertEquals("External DTD: Failed to read external DTD 'mathml.dtd', because 'http' access is not allowed due to restriction set by the accessExternalDTD property.", e.getCause().getCause().getMessage());
try {
new DataDictionary("FIX_External_DTD.xml");
fail("should fail to load dictionary with external DTD");
} catch (ConfigError e) {
assertEquals("External DTD: Failed to read external DTD 'mathml.dtd', because 'http' access is not allowed due to restriction set by the accessExternalDTD property.", e.getCause().getCause().getMessage());
}
} finally {
Locale.setDefault(originalLocale);
}
}

Expand Down