Skip to content

Fix intermittent shouldFailWhenUsingEmptyServerKeyStore test failure across platforms #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrjohn merged 4 commits into from
Dec 15, 2025
Merged

Fix intermittent shouldFailWhenUsingEmptyServerKeyStore test failure across platforms #1094

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9c66114
Initial plan
Copilot Dec 12, 2025
253e491
Fix intermittent SSLCertificateTest failure by using explicit cipher …
Copilot Dec 12, 2025
eb7a664
Use comprehensive cipher suite list for Windows JDK 21 compatibility
Copilot Dec 14, 2025
8a4182e
Increase timeout from 5 to 15 seconds
chrjohn Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions quickfixj-core/src/test/java/quickfix/mina/ssl/SSLCertificateTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,23 @@ public class SSLCertificateTest {

private static final String LOCALHOST_ALIAS = "localhost-quickfixj";

// Cipher suites that require certificates (excludes anonymous suites)
// This list provides compatibility across different JDK versions and platforms
private static final String CERTIFICATE_REQUIRED_CIPHER_SUITES = String.join(",",
"TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256",
"TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384",
"TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256",
"TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384",
"TLS_RSA_WITH_AES_128_GCM_SHA256",
"TLS_RSA_WITH_AES_256_GCM_SHA384",
"TLS_RSA_WITH_AES_128_CBC_SHA256",
"TLS_RSA_WITH_AES_256_CBC_SHA256",
"TLS_RSA_WITH_AES_128_CBC_SHA",
"TLS_RSA_WITH_AES_256_CBC_SHA",
"TLS_AES_128_GCM_SHA256",
"TLS_AES_256_GCM_SHA384"
);

@Parameters
public static List<Object[]> parameters() {
return Arrays.asList(new String[][]{{"TLS_RSA_WITH_AES_128_CBC_SHA", "TLSv1.2"}, {"TLS_AES_256_GCM_SHA384", "TLSv1.3"}});
Expand Down Expand Up @@ -794,13 +811,13 @@ public void shouldFailIndividualSessionsWhenInvalidCertificatesUsed() throws Exc
public void shouldFailWhenUsingEmptyServerKeyStore() throws Exception {
int freePort = AvailablePortFinder.getNextAvailable();
TestAcceptor acceptor = new TestAcceptor(createAcceptorSettings("single-session/empty.keystore", false,
"single-session/empty.keystore", null, null, "JKS", "JKS", freePort));
"single-session/empty.keystore", CERTIFICATE_REQUIRED_CIPHER_SUITES, "TLSv1.2,TLSv1.3", "JKS", "JKS", freePort));

try {
acceptor.start();

TestInitiator initiator = new TestInitiator(createInitiatorSettings("single-session/empty.keystore",
"single-session/empty.keystore", null, null, "ZULU", "ALFA", Integer.toString(freePort), "JKS", "JKS"));
"single-session/empty.keystore", CERTIFICATE_REQUIRED_CIPHER_SUITES, "TLSv1.2,TLSv1.3", "ZULU", "ALFA", Integer.toString(freePort), "JKS", "JKS"));

try {
initiator.start();
Expand Down Expand Up @@ -992,7 +1009,7 @@ public void shouldConnectDifferentTypesOfSessions() throws Exception {

static abstract class TestConnector {
private static final Logger LOGGER = LoggerFactory.getLogger(TestConnector.class);
private static final int TIMEOUT_SECONDS = 5;
private static final int TIMEOUT_SECONDS = 15;

private final SessionConnector connector;
private final CountDownLatch exceptionThrownLatch;
Expand Down