From eeaaedba9ad33d723de49e106b6b254a7f04c9d4 Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Thu, 18 Dec 2025 16:00:01 +0000
Subject: [PATCH 1/3] Initial plan


From 1ce8c21cc32251659645fc213370fcb1f1f0a983 Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Thu, 18 Dec 2025 16:10:36 +0000
Subject: [PATCH 2/3] Replace logError() with Session.getLog() in
 SessionConnector

Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
---
 .../src/main/java/quickfix/mina/SessionConnector.java      | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/quickfixj-core/src/main/java/quickfix/mina/SessionConnector.java b/quickfixj-core/src/main/java/quickfix/mina/SessionConnector.java
index 675387a6e0..410deb5ed3 100644
--- a/quickfixj-core/src/main/java/quickfix/mina/SessionConnector.java
+++ b/quickfixj-core/src/main/java/quickfix/mina/SessionConnector.java
@@ -27,6 +27,7 @@
 import quickfix.Connector;
 import quickfix.ExecutorFactory;
 import quickfix.FieldConvertError;
+import quickfix.LogUtil;
 import quickfix.Session;
 import quickfix.SessionFactory;
 import quickfix.SessionID;
@@ -243,7 +244,7 @@ protected void logoutAllSessions(boolean forceDisconnect) {
             try {
                 session.logout();
             } catch (Throwable e) {
-                logError(session.getSessionID(), null, "Error during logout", e);
+                LogUtil.logThrowable(session.getLog(), "Error during logout", e);
             }
         }
 
@@ -255,7 +256,7 @@ protected void logoutAllSessions(boolean forceDisconnect) {
                             session.disconnect("Forcibly disconnecting session", false);
                         }
                     } catch (Throwable e) {
-                        logError(session.getSessionID(), null, "Error during disconnect", e);
+                        LogUtil.logThrowable(session.getLog(), "Error during disconnect", e);
                     }
                 }
             } else {
@@ -347,7 +348,7 @@ public void run() {
                     try {
                         session.next();
                     } catch (IOException e) {
-                        logError(session.getSessionID(), null, "Error in session timer processing", e);
+                        LogUtil.logThrowable(session.getLog(), "Error in session timer processing", e);
                     }
                 }
             } catch (Throwable e) {

From 9e29ecf0e1517e1fb54ec2f68a30e47f1fa4a0d6 Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Thu, 18 Dec 2025 17:43:50 +0000
Subject: [PATCH 3/3] Remove unused logError() and getLogSuffix() methods from
 SessionConnector

Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
---
 .../main/java/quickfix/mina/SessionConnector.java | 15 ---------------
 1 file changed, 15 deletions(-)

diff --git a/quickfixj-core/src/main/java/quickfix/mina/SessionConnector.java b/quickfixj-core/src/main/java/quickfix/mina/SessionConnector.java
index 410deb5ed3..555da68678 100644
--- a/quickfixj-core/src/main/java/quickfix/mina/SessionConnector.java
+++ b/quickfixj-core/src/main/java/quickfix/mina/SessionConnector.java
@@ -296,21 +296,6 @@ protected void waitForLogout() {
         }
     }
 
-    protected void logError(SessionID sessionID, IoSession protocolSession, String message, Throwable t) {
-        log.error(message + getLogSuffix(sessionID, protocolSession), t);
-    }
-
-    private String getLogSuffix(SessionID sessionID, IoSession protocolSession) {
-        String suffix = ":";
-        if (sessionID != null) {
-            suffix += "sessionID=" + sessionID.toString() + ";";
-        }
-        if (protocolSession != null) {
-            suffix += "address=" + protocolSession.getRemoteAddress();
-        }
-        return suffix;
-    }
-
     protected void startSessionTimer() {
         Runnable timerTask = new SessionTimerTask();
         if (shortLivedExecutor != null) {