Replace deprecated TLS cipher suite in SSLCertificateTest#1121
Merged
Conversation
…_128_GCM_SHA256 Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
…ES constant Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix SSLCertificateTest to use non-deprecated cipher suite
Replace deprecated TLS cipher suite in SSLCertificateTest
Jan 21, 2026
SSLCertificateTest
Member
|
@copilot this does not look good, errors are the same. Please have a look. |
Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
Contributor
Author
Fixed in commit 2f524f9. The issue was that ALL Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
chrjohn
added a commit
that referenced
this pull request
Feb 23, 2026
…test Replace deprecated TLS cipher suite in `SSLCertificateTest` (cherry picked from commit 2b1a850)
chrjohn
added a commit
that referenced
this pull request
Feb 23, 2026
Merge pull request #1121 from quickfix-j/copilot/fix-ssl-certificate-…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSLCertificateTestfails on newer JDKs becauseTLS_RSA_WITH_AES_128_CBC_SHAis deprecated per IETF draft-ietf-tls-deprecate-obsolete-kex.Changes
TLS_RSA_WITH_AES_128_CBC_SHAwithTLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256in parameterized test configurationTLS_RSA_WITH_AES_128_CBC_SHAandTLS_RSA_WITH_AES_256_CBC_SHAfromCERTIFICATE_REQUIRED_CIPHER_SUITESconstantThe replacement cipher suite provides forward secrecy via ECDHE (Elliptic Curve Diffie-Hellman Ephemeral) key exchange and modern AES-GCM authenticated encryption while maintaining TLSv1.2 compatibility. This addresses the IETF deprecation of ALL cipher suites using static RSA key exchange (all
TLS_RSA_*suites), not just CBC mode.Original prompt
SSLCertificateTestfails with newer JDKs</issue_title><issue_description>This is most probably due to the deprecation of cipher suite
TLS_RSA_WITH_AES_128_CBC_SHAwhich is used in this test.See https://datatracker.ietf.org/doc/draft-ietf-tls-deprecate-obsolete-kex/
We should use an alternative cipher suite which is not deprecated.
</issue_description>
Comments on the Issue (you are @copilot in this section)
Original prompt
SSLCertificateTestfails with newer JDKs #1120✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.