Skip to content

Suppress noisy WriteToClosedSessionException errors on session teardown #1143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Suppress noisy WriteToClosedSessionException errors on session teardown #1143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c4910a
Initial plan
Copilot Feb 19, 2026
f399c96
Handle WriteToClosedSessionException gracefully in AbstractIoHandler …
Copilot Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion quickfixj-core/src/main/java/quickfix/mina/AbstractIoHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import java.io.IOException;
import org.apache.mina.core.service.IoHandlerAdapter;
import org.apache.mina.core.session.IoSession;
import org.apache.mina.core.write.WriteToClosedSessionException;
import org.apache.mina.filter.codec.ProtocolCodecException;
import org.apache.mina.filter.codec.ProtocolDecoderException;
import org.slf4j.Logger;
Expand Down Expand Up @@ -81,7 +82,10 @@ public void exceptionCaught(IoSession ioSession, Throwable cause) throws Excepti
}
}
String reason;
if (realCause instanceof IOException) {
if (realCause instanceof WriteToClosedSessionException) {
log.debug("Write to closed session ({}): {}", ioSession.getRemoteAddress(), cause.getMessage());
return;
} else if (realCause instanceof IOException) {
if (quickFixSession != null && quickFixSession.isEnabled()) {
reason = "Socket exception (" + ioSession.getRemoteAddress() + "): " + cause;
} else {
Expand Down
23 changes: 23 additions & 0 deletions quickfixj-core/src/test/java/quickfix/mina/acceptor/AcceptorIoHandlerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@
package quickfix.mina.acceptor;

import org.apache.mina.core.session.IoSession;
import org.apache.mina.core.write.DefaultWriteRequest;
import org.apache.mina.core.write.WriteToClosedSessionException;
import org.junit.Test;
import quickfix.FixVersions;
import quickfix.Message;
Expand Down Expand Up @@ -403,6 +405,27 @@ public void testRejectGarbledMessageWithoutMsgTypeBeforeSessionIsCreated() throw
}
}

// QFJ-928
@Test
public void testWriteToClosedSessionExceptionIsHandledGracefully() throws Exception {
IoSession mockIoSession = mock(IoSession.class);
SessionSettings settings = mock(SessionSettings.class);
EventHandlingStrategy mockEventHandlingStrategy = mock(EventHandlingStrategy.class);

when(mockIoSession.getAttribute("QF_SESSION")).thenReturn(null);

AcceptorIoHandler handler = new AcceptorIoHandler(createSessionProvider(new HashMap<>()),
settings, new NetworkingOptions(new Properties()), mockEventHandlingStrategy);

WriteToClosedSessionException exception = new WriteToClosedSessionException(new DefaultWriteRequest("test"));
// Should not throw and should not call setAttribute for QFJ_RESET_IO_CONNECTOR
handler.exceptionCaught(mockIoSession, exception);

verify(mockIoSession).getAttribute("QF_SESSION");
verify(mockIoSession).getRemoteAddress();
verifyNoMoreInteractions(mockIoSession);
}

private class UnitTestResponder implements Responder {

public String sentMessageData;
Expand Down
Loading