From 7a54eae1f1733495f1c154a7ad205253d2b1c3e3 Mon Sep 17 00:00:00 2001 From: Christoph John Date: Thu, 22 May 2025 18:04:07 +0200 Subject: [PATCH 1/5] try to delete complete version --- .github/workflows/nightly-build.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/nightly-build.yml b/.github/workflows/nightly-build.yml index 2e2cd0c69f..86cfdd3825 100644 --- a/.github/workflows/nightly-build.yml +++ b/.github/workflows/nightly-build.yml @@ -34,6 +34,7 @@ jobs: with: organization: quickfix-j type: maven + keep: 0 names: | org.quickfixj.quickfixj-all org.quickfixj.quickfixj-base From 3f1dbbee61360e0fc8328b345547bb15ddcef277 Mon Sep 17 00:00:00 2001 From: Christoph John Date: Thu, 22 May 2025 18:43:33 +0200 Subject: [PATCH 2/5] move deletion of packages to front --- .github/workflows/nightly-build.yml | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/.github/workflows/nightly-build.yml b/.github/workflows/nightly-build.yml index 86cfdd3825..ea3d2a119a 100644 --- a/.github/workflows/nightly-build.yml +++ b/.github/workflows/nightly-build.yml @@ -17,18 +17,6 @@ jobs: steps: - uses: actions/checkout@v4 - - name: Set up JDK - uses: actions/setup-java@v4 - with: - distribution: temurin - java-version: 21 - cache: maven - - - name: Build and Publish SNAPSHOT - run: ./mvnw deploy -B -V -D"maven.javadoc.skip"="true" -D"java.util.logging.config.file"="${{github.workspace}}/quickfixj-core/src/test/resources/logging.properties" -D"http.keepAlive"="false" -D"maven.wagon.http.pool"="false" -D"maven.wagon.httpconnectionManager.ttlSeconds"="120" - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - - name: Delete old packages uses: SmartsquareGmbH/delete-old-packages@v0.8.1 with: @@ -62,3 +50,15 @@ jobs: org.quickfixj.quickfixj-orchestration org.quickfixj.quickfixj-parent org.quickfixj.quickfixj-perf-test + + - name: Set up JDK + uses: actions/setup-java@v4 + with: + distribution: temurin + java-version: 21 + cache: maven + + - name: Build and Publish SNAPSHOT + run: ./mvnw deploy -B -V -D"maven.javadoc.skip"="true" -D"java.util.logging.config.file"="${{github.workspace}}/quickfixj-core/src/test/resources/logging.properties" -D"http.keepAlive"="false" -D"maven.wagon.http.pool"="false" -D"maven.wagon.httpconnectionManager.ttlSeconds"="120" + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} From fe6919e3633eff0f7b100990891031edee2966c5 Mon Sep 17 00:00:00 2001 From: Christoph John Date: Fri, 23 May 2025 11:24:08 +0200 Subject: [PATCH 3/5] continue if there are no packages to delete --- .github/workflows/nightly-build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/nightly-build.yml b/.github/workflows/nightly-build.yml index ea3d2a119a..a7255d7717 100644 --- a/.github/workflows/nightly-build.yml +++ b/.github/workflows/nightly-build.yml @@ -16,8 +16,8 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - - name: Delete old packages + continue-on-error: true uses: SmartsquareGmbH/delete-old-packages@v0.8.1 with: organization: quickfix-j From 731419e60753f88dbdb814b04ee3b5fde4ac2661 Mon Sep 17 00:00:00 2001 From: Christoph John Date: Fri, 23 May 2025 11:47:26 +0200 Subject: [PATCH 4/5] split into build and deploy step --- .github/workflows/nightly-build.yml | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/.github/workflows/nightly-build.yml b/.github/workflows/nightly-build.yml index a7255d7717..0fc94a65ff 100644 --- a/.github/workflows/nightly-build.yml +++ b/.github/workflows/nightly-build.yml @@ -16,6 +16,16 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 + - name: Set up JDK + uses: actions/setup-java@v4 + with: + distribution: temurin + java-version: 21 + cache: maven + + - name: Build SNAPSHOT + run: ./mvnw clean package -B -V -D"maven.javadoc.skip"="true" -D"java.util.logging.config.file"="${{github.workspace}}/quickfixj-core/src/test/resources/logging.properties" -D"http.keepAlive"="false" -D"maven.wagon.http.pool"="false" -D"maven.wagon.httpconnectionManager.ttlSeconds"="120" + - name: Delete old packages continue-on-error: true uses: SmartsquareGmbH/delete-old-packages@v0.8.1 @@ -51,14 +61,7 @@ jobs: org.quickfixj.quickfixj-parent org.quickfixj.quickfixj-perf-test - - name: Set up JDK - uses: actions/setup-java@v4 - with: - distribution: temurin - java-version: 21 - cache: maven - - - name: Build and Publish SNAPSHOT + - name: Deploy SNAPSHOT run: ./mvnw deploy -B -V -D"maven.javadoc.skip"="true" -D"java.util.logging.config.file"="${{github.workspace}}/quickfixj-core/src/test/resources/logging.properties" -D"http.keepAlive"="false" -D"maven.wagon.http.pool"="false" -D"maven.wagon.httpconnectionManager.ttlSeconds"="120" env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} From 126040da2350c075e6c5df75714293c2fd3a85a9 Mon Sep 17 00:00:00 2001 From: Christoph John Date: Fri, 23 May 2025 18:39:49 +0200 Subject: [PATCH 5/5] Skip tests on deploy to speed things up --- .github/workflows/nightly-build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/nightly-build.yml b/.github/workflows/nightly-build.yml index 0fc94a65ff..9598021b51 100644 --- a/.github/workflows/nightly-build.yml +++ b/.github/workflows/nightly-build.yml @@ -62,6 +62,6 @@ jobs: org.quickfixj.quickfixj-perf-test - name: Deploy SNAPSHOT - run: ./mvnw deploy -B -V -D"maven.javadoc.skip"="true" -D"java.util.logging.config.file"="${{github.workspace}}/quickfixj-core/src/test/resources/logging.properties" -D"http.keepAlive"="false" -D"maven.wagon.http.pool"="false" -D"maven.wagon.httpconnectionManager.ttlSeconds"="120" + run: ./mvnw deploy -B -V -DskipTests -D"maven.javadoc.skip"="true" -D"java.util.logging.config.file"="${{github.workspace}}/quickfixj-core/src/test/resources/logging.properties" -D"http.keepAlive"="false" -D"maven.wagon.http.pool"="false" -D"maven.wagon.httpconnectionManager.ttlSeconds"="120" env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}