Improve disconnect reason when ResetOnLogon is not honoured by counter party#988
Merged
chrjohn merged 5 commits intoJul 10, 2025
Conversation
…r-party This fixes quickfix-j#960 by clarifying the reason for sequence number in response not being 1 when resetOnLogon is configured to true.
chrjohn
changed the title
ResetOnLogon is not honoured by counter party
chrjohn
requested changes
Jun 23, 2025
-This removed disconnect case is covered on Line 2216. Also removed case for resetOnLogon. Since we're checking for isResetSent(), the check on resetOnLogon should be redundant. -Added return statement after disconnect(). This is behaviour is a bit inconsistent in the Session class, however it prevents duplicated state reset updates that are covered in disconnect().
…for_reset_on_login
chrjohn
approved these changes
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #960 by clarifying the reason for sequence number in response not being 1 when resetOnLogon is configured to true.
As far as I could tell, it isn't necessary to add/amend a unit test for this fix as the disconnect is already tested by SessionTest.testInferResetSeqNumAcceptedWithNonInitialSequenceNumber()