Update CI configuration to use Visual Studio 18

Author: saghul

.github/workflows/ci.yml

@@ -178,17 +178,17 @@ jobs:
       fail-fast: false
       matrix:
         config:
-          - { arch: x64, vsArch: x64, buildType: Debug, os: windows-latest }
-          - { arch: x64, vsArch: x64, buildType: Release, os: windows-latest }
-          - { arch: Win32, vsArch: x86, buildType: Debug, os: windows-latest }
-          - { arch: Win32, vsArch: x86, buildType: Release, os: windows-latest }
-          - { arch: ARM64, vsArch: arm64, buildType: Debug, os: windows-11-arm }
-          - { arch: ARM64, vsArch: arm64, buildType: Release, os: windows-11-arm }
+          - { arch: x64, vsArch: x64, buildType: Debug, os: windows-latest, msvc: 18 }
+          - { arch: x64, vsArch: x64, buildType: Release, os: windows-latest, msvc: 18 }
+          - { arch: Win32, vsArch: x86, buildType: Debug, os: windows-latest, msvc: 18 }
+          - { arch: Win32, vsArch: x86, buildType: Release, os: windows-latest, msvc: 18 }
+          - { arch: ARM64, vsArch: arm64, buildType: Debug, os: windows-11-arm, msvc: 17 }
+          - { arch: ARM64, vsArch: arm64, buildType: Release, os: windows-11-arm, msvc: 17 }
     steps:
       - uses: actions/checkout@v6
       - name: build
         run: |
-          cmake -B build -DQJS_BUILD_WERROR=ON -DQJS_BUILD_EXAMPLES=ON -G "Visual Studio 17 2022" -A ${{matrix.config.arch}}
+          cmake -B build -DQJS_BUILD_WERROR=ON -DQJS_BUILD_EXAMPLES=ON -G "Visual Studio ${{matrix.config.msvc}}" -A ${{matrix.config.arch}}
           cmake --build build --config ${{matrix.config.buildType}}
       - name: stats
         run: |
@@ -264,7 +264,7 @@ jobs:
       - name: build
         run: |
           git submodule update --init --checkout --depth 1
-          cmake -B build -DQJS_BUILD_WERROR=ON -DQJS_BUILD_EXAMPLES=ON -G "Visual Studio 17 2022" -T ClangCL
+          cmake -B build -DQJS_BUILD_WERROR=ON -DQJS_BUILD_EXAMPLES=ON -G "Visual Studio 18" -T ClangCL
           cmake --build build --config ${{matrix.buildType}}
       - name: stats
         run: |
@@ -717,13 +717,20 @@ jobs:
 
           # default clang on GitHub hosted runners is from MSYS2.
           # Use Visual Studio supplied clang-cl instead.
+          # clang-cl's AddressSanitizer does not support the debug CRT (/MDd),
+          # so force the release CRT (/MD) for both debug and release builds.
           - name: clang-cl+sanitize
             args: >-
               "-Db_sanitize=address,undefined"
               "-Db_lundef=false"
+              "-Db_vscrt=md"
             extra_envs:
               CC: clang-cl
               CXX: clang-cl
+              # clang-cl's AddressSanitizer reports false positive
+              # global-buffer-overflows on pooled string literals on Windows,
+              # same as MSVC; disable global checks (covered on Linux).
+              ASAN_OPTIONS: report_globals=0:halt_on_error=1:abort_on_error=1:print_summary=1
         platform:
           - ubuntu-latest
           - windows-latest
@@ -822,7 +829,21 @@ jobs:
         if: ${{ matrix.platform == 'windows-latest' }}
         env: ${{ matrix.mode.extra_envs }}
         run: |
-          meson setup build-${{ matrix.flavor }} --buildtype=${{ matrix.flavor }} ${{ matrix.mode.args }} ${{ matrix.features.args }} --vsenv
+          $extraArgs = @()
+          if ($env:CC -eq 'clang-cl') {
+            # Newer clang-cl no longer emits the asan runtime /defaultlib directives
+            # when -fsanitize is passed through /clang:, and meson links with lld-link
+            # directly (not the clang driver), so the asan/ubsan runtime is never pulled
+            # in. Link it explicitly and make its directory discoverable at link and run
+            # time (the dynamic runtime ships as a DLL).
+            $runtimeDir = (clang -print-runtime-dir).Trim()
+            $env:LIB = "$runtimeDir;$env:LIB"
+            "LIB=$env:LIB" | Out-File -FilePath $env:GITHUB_ENV -Append -Encoding utf8
+            $runtimeDir | Out-File -FilePath $env:GITHUB_PATH -Append -Encoding utf8
+            $libs = "clang_rt.asan_dynamic-x86_64.lib clang_rt.asan_dynamic_runtime_thunk-x86_64.lib"
+            $extraArgs = @("-Dc_link_args=$libs", "-Dcpp_link_args=$libs")
+          }
+          meson setup build-${{ matrix.flavor }} --buildtype=${{ matrix.flavor }} ${{ matrix.mode.args }} ${{ matrix.features.args }} --vsenv @extraArgs
       - name: Configuring
         if: ${{ matrix.platform != 'windows-latest' }}
         env: ${{ matrix.mode.extra_envs }}