max_uint32 substitution is the minimal patch for an introduced fix to…#1468
Merged
Conversation
Contributor
Author
|
The failed tests, OOM is expected from the poc testcase since the OOB path is now guarded. Happy to add a simple check try/except catch in the poc if required for passing all checks |
saghul
approved these changes
May 12, 2026
Contributor
|
Yeah the CI should have a test that passes... |
…ht guard. Test poc should also pass now
saghul
reviewed
May 12, 2026
saghul
reviewed
May 12, 2026
Contributor
Author
|
All checks passed and suggestions added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long term solution is the slow-array conversion is the semantically correct fix for supporting arrays with more than 2^31 elements.