Update test262#1539
Merged
Merged
Conversation
Bump the test262 submodule. The version jump pulls in tests for two staged proposals that are not implemented here yet: - error-stack-accessor: skipped in test262.conf until the accessor lands. - immutable ArrayBuffer write paths: the new expected failures are recorded in test262_errors.txt and will be removed as each fix lands. Also relabels the subarray/byteoffset-with-detached-buffer expectations (makePassthrough -> makeArrayBuffer) to match the updated test.
saghul
force-pushed
the
test262-bump-and-fixes
branch
from
b487298 to
d257e16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump the test262 submodule to
de8e621.The version jump pulls in tests for two staged proposals that are not implemented here yet, so this PR lands the bump green by recording the gaps rather than fixing them:
error-stack-accessor— skipped intest262.confuntil the accessor lands (Implement Error.prototype.stack accessor proposal #1536).test262_errors.txt, removed as each fix lands (Enforce immutability on TypedArray write paths #1537, Fix ArrayBuffer immutable-method semantics #1538).Also relabels the
subarray/byteoffset-with-detached-bufferexpectations (makePassthrough→makeArrayBuffer) to match the updated test.Merge this first; the fix PRs each rebase onto it and remove their own entries from the errorfile (the runner treats a fixed error as a failure too, so each fix PR is green only if it genuinely works).