chore(basics/counter): remove legacy mpl-stack (Shank+Solita) example#64
Merged
Conversation
… superseded by tools/shank-and-codama)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
basics/counter/mpl-stack— a native counter that demonstrated the Metaplex "stack" (Shank IDL → Solita TS client). It's redundant and was the one example no CI workflow covered:mpl-stack) isn't in any workflow's discovery set (native/anchor/quasar/pinocchio/asm), so it was never functionally tested — only host-linted as a workspace member. Its test is jest against a local validator, which can't run in CI in-process anyway.basics/counter/{native,anchor,pinocchio,asm}(all CI-tested).tools/shank-and-codama— Solita is unmaintained (last release Nov 2023; superseded by Kinobi → Codama).So it adds no unique teaching value and was a permanent CI blind spot. Removing it (and its root
Cargo.tomlworkspace-member entry) closes the last gap found in a full repo sweep —.github/.ghaignoreis empty, and every remaining example dir is discovered by a framework workflow.cargo metadataconfirms the workspace still resolves after removal.https://claude.ai/code/session_013dpnF6uSGWXjkJJZseqzcP
Generated by Claude Code