Skip to content

chore(basics/counter): remove legacy mpl-stack (Shank+Solita) example#64

Merged
mikemaccana merged 1 commit into
mainfrom
claude/remove-mpl-stack
Jun 6, 2026
Merged

chore(basics/counter): remove legacy mpl-stack (Shank+Solita) example#64
mikemaccana merged 1 commit into
mainfrom
claude/remove-mpl-stack

Conversation

@mikemaccana

Copy link
Copy Markdown
Collaborator

Summary

Removes basics/counter/mpl-stack — a native counter that demonstrated the Metaplex "stack" (Shank IDL → Solita TS client). It's redundant and was the one example no CI workflow covered:

  • Its dir name (mpl-stack) isn't in any workflow's discovery set (native/anchor/quasar/pinocchio/asm), so it was never functionally tested — only host-linted as a workspace member. Its test is jest against a local validator, which can't run in CI in-process anyway.
  • Its counter logic is already shown by basics/counter/{native,anchor,pinocchio,asm} (all CI-tested).
  • Its Shank → generated-client lesson is now covered with the current tool by tools/shank-and-codamaSolita is unmaintained (last release Nov 2023; superseded by Kinobi → Codama).

So it adds no unique teaching value and was a permanent CI blind spot. Removing it (and its root Cargo.toml workspace-member entry) closes the last gap found in a full repo sweep — .github/.ghaignore is empty, and every remaining example dir is discovered by a framework workflow.

cargo metadata confirms the workspace still resolves after removal.

https://claude.ai/code/session_013dpnF6uSGWXjkJJZseqzcP


Generated by Claude Code

@mikemaccana mikemaccana merged commit d91b718 into main Jun 6, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants