Skip to content

Commit 09c32ad

Browse files
committed
Fix default service startup in tests
1 parent 2002587 commit 09c32ad

5 files changed

Lines changed: 9 additions & 9 deletions

File tree

quickwit/quickwit-cli/src/service.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,10 @@ use crate::{config_cli_arg, get_resolvers, load_node_config, start_actor_runtime
3434
pub fn build_run_command() -> Command {
3535
Command::new("run")
3636
.about("Starts a Quickwit node.")
37-
.long_about("Starts a Quickwit node with all services enabled by default: `indexer`, `searcher`, `metastore`, `control-plane`, and `janitor`.")
37+
.long_about("Starts a Quickwit node with the default services enabled: `indexer`, `searcher`, `metastore`, `control-plane`, and `janitor`.")
3838
.arg(config_cli_arg())
3939
.args(&[
40-
arg!(--"service" <SERVICE> "Services (`indexer`, `searcher`, `metastore`, `control-plane`, or `janitor`) to run. If unspecified, all the supported services are started.")
40+
arg!(--"service" <SERVICE> "Services (`indexer`, `searcher`, `metastore`, `metastore-read-replica`, `control-plane`, or `janitor`) to run. If unspecified, services from the config are used.")
4141
.action(ArgAction::Append)
4242
.required(false),
4343
])

quickwit/quickwit-cli/tests/helpers.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ impl TestEnv {
157157
pub async fn start_server(&self) -> anyhow::Result<()> {
158158
let run_command = RunCliCommand {
159159
config_uri: self.resource_files.config.clone(),
160-
services: Some(QuickwitService::supported_services()),
160+
services: Some(QuickwitService::default_services()),
161161
};
162162
let server_handle = tokio::spawn(async move {
163163
if let Err(error) = run_command

quickwit/quickwit-integration-tests/src/test_utils/cluster_sandbox.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ impl ClusterSandboxBuilder {
201201

202202
pub async fn build_and_start_standalone() -> ClusterSandbox {
203203
ClusterSandboxBuilder::default()
204-
.add_node(QuickwitService::supported_services())
204+
.add_node(QuickwitService::default_services())
205205
.build_config()
206206
.await
207207
.start()

quickwit/quickwit-integration-tests/src/tests/metrics_distributed_tests.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ async fn test_distributed_tasks_not_shuffles() {
201201
quickwit_common::setup_logging_for_tests();
202202

203203
let sandbox = ClusterSandboxBuilder::default()
204-
.add_node(QuickwitService::supported_services())
204+
.add_node(QuickwitService::default_services())
205205
.add_node([QuickwitService::Searcher])
206206
.build_and_start()
207207
.await;

quickwit/quickwit-integration-tests/src/tests/tls_tests.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ async fn fetch_served_leaf_cert(addr: SocketAddr, ca_path: &str) -> Vec<u8> {
8080
async fn test_tls_rest() {
8181
quickwit_common::setup_logging_for_tests();
8282
let mut sandbox_config = ClusterSandboxBuilder::default()
83-
.add_node(QuickwitService::supported_services())
83+
.add_node(QuickwitService::default_services())
8484
.build_config()
8585
.await;
8686
sandbox_config.node_configs[0].0.rest_config.tls_config = Some(fixture_tls_config());
@@ -192,7 +192,7 @@ async fn test_tls_grpc() {
192192
async fn test_mtls_rest() {
193193
quickwit_common::setup_logging_for_tests();
194194
let mut sandbox_config = ClusterSandboxBuilder::default()
195-
.add_node(QuickwitService::supported_services())
195+
.add_node(QuickwitService::default_services())
196196
.build_config()
197197
.await;
198198
// Reuse the server cert/key as the client identity — it is signed by the same CA, so the
@@ -244,7 +244,7 @@ async fn test_mtls_rest() {
244244
async fn test_health_check_server_plaintext_with_mtls_rest() {
245245
quickwit_common::setup_logging_for_tests();
246246
let mut sandbox_config = ClusterSandboxBuilder::default()
247-
.add_node(QuickwitService::supported_services())
247+
.add_node(QuickwitService::default_services())
248248
.enable_health_check()
249249
.build_config()
250250
.await;
@@ -294,7 +294,7 @@ async fn test_tls_rest_cert_hot_reload() {
294294
let ca_path = format!("{TLS_FIXTURES_DIR}/ca.crt");
295295

296296
let mut sandbox_config = ClusterSandboxBuilder::default()
297-
.add_node(QuickwitService::supported_services())
297+
.add_node(QuickwitService::default_services())
298298
.build_config()
299299
.await;
300300
sandbox_config.node_configs[0].0.rest_config.tls_config = Some(TlsConfig {

0 commit comments

Comments
 (0)