allow deprecated calls to prost (#6251)

* allow deprecated calls to prost

* fix deprecation warning with tempdir

* add curl apparently required for rdkafka now

Author: trinity-1686a

.github/workflows/ci.yml

@@ -143,7 +143,7 @@ jobs:
         if: always() && steps.modified.outputs.rust_src == 'true'
         run: |
           sudo apt-get update
-          sudo apt-get -y install protobuf-compiler
+          sudo apt-get -y install protobuf-compiler libcurl4-openssl-dev
       - name: Setup nightly Rust Toolchain (for rustfmt)
         if: steps.modified.outputs.rust_src == 'true'
         uses: dtolnay/rust-toolchain@efa25f7f19611383d5b0ccf2d1c8914531636bf9 # master

quickwit/quickwit-proto/src/types/doc_mapping_uid.rs

@@ -99,6 +99,7 @@ impl prost::Message for DocMappingUid {
                 )?;
                 let ulid_bytes: [u8; ULID_SIZE] =
                     buffer.try_into().map_err(|buffer: Vec<u8>| {
+                        #[allow(deprecated)]
                         prost::DecodeError::new(format!(
                             "invalid length for field `doc_mapping_uid`, expected 16 bytes, got {}",
                             buffer.len()

quickwit/quickwit-proto/src/types/doc_uid.rs

@@ -98,6 +98,7 @@ impl prost::Message for DocUid {
                 )?;
                 let ulid_bytes: [u8; ULID_SIZE] =
                     buffer.try_into().map_err(|buffer: Vec<u8>| {
+                        #[allow(deprecated)]
                         prost::DecodeError::new(format!(
                             "invalid length for field `doc_uid`, expected 16 bytes, got {}",
                             buffer.len()

quickwit/quickwit-proto/src/types/index_uid.rs

@@ -137,6 +137,7 @@ impl prost::Message for IndexUid {
                 )?;
                 let ulid_bytes: [u8; ULID_SIZE] =
                     buffer.try_into().map_err(|buffer: Vec<u8>| {
+                        #[allow(deprecated)]
                         prost::DecodeError::new(format!(
                             "invalid length for field `incarnation_id`, expected 16 bytes, got {}",
                             buffer.len()

quickwit/quickwit-proto/src/types/pipeline_uid.rs

@@ -102,6 +102,7 @@ impl prost::Message for PipelineUid {
                 )?;
                 let ulid_bytes: [u8; ULID_SIZE] =
                     buffer.try_into().map_err(|buffer: Vec<u8>| {
+                        #[allow(deprecated)]
                         prost::DecodeError::new(format!(
                             "invalid length for field `pipeline_uid`, expected 16 bytes, got {}",
                             buffer.len()

quickwit/quickwit-proto/src/types/position.rs

@@ -273,6 +273,7 @@ impl prost::Message for Position {
                         error
                     },
                 )?;
+                #[allow(deprecated)]
                 let byte_string = ByteString::try_from(value)
                     .map_err(|_| DecodeError::new("position is not valid UTF-8"))?;
                 *self = Self::from(byte_string);

quickwit/quickwit-proto/src/types/shard_id.rs

@@ -104,6 +104,7 @@ impl prost::Message for ShardId {
                         error
                     },
                 )?;
+                #[allow(deprecated)]
                 let byte_string = ByteString::try_from(value)
                     .map_err(|_| DecodeError::new("shard_id is not valid UTF-8"))?;
                 *self = Self(byte_string);

quickwit/quickwit-storage/src/storage.rs

@@ -181,7 +181,7 @@ impl DownloadTempFile {
     }
 
     pub async fn persist(mut self) -> io::Result<u64> {
-        TempPath::from_path(&self.temp_filepath).persist(&self.target_filepath)?;
+        TempPath::try_from_path(&self.temp_filepath)?.persist(&self.target_filepath)?;
         self.has_attempted_deletion = true;
         let num_bytes = std::fs::metadata(&self.target_filepath)?.len();
         Ok(num_bytes)