Fix clippy warnings

Author: guilload

quickwit/quickwit-actors/src/registry.rs

@@ -166,8 +166,7 @@ impl ActorRegistry {
 
     pub fn get_one<A: Actor>(&self) -> Option<Mailbox<A>> {
         let mut lock = self.actors.write().unwrap();
-        let opt = get_iter::<A>(&mut lock).next();
-        opt
+        get_iter::<A>(&mut lock).next()
     }
 
     fn gc(&self) {

quickwit/quickwit-cli/src/index.rs

@@ -785,14 +785,12 @@ impl IndexStats {
             tables.push(size_stats_table);
         }
 
-        let table = Table::builder(tables.into_iter().map(|table| table.to_string()))
+        Table::builder(tables.into_iter().map(|table| table.to_string()))
             .build()
             .with(Modify::new(Segment::all()).with(Alignment::center_vertical()))
             .with(Disable::row(FirstRow))
             .with(Style::empty())
-            .to_string();
-
-        table
+            .to_string()
     }
 }
 

quickwit/quickwit-common/src/io.rs

@@ -125,10 +125,7 @@ impl IoControls {
 
     pub fn check_if_alive(&self) -> io::Result<ProtectedZoneGuard> {
         if self.kill_switch.is_dead() {
-            return Err(io::Error::new(
-                io::ErrorKind::Other,
-                "Directory kill switch was activated.",
-            ));
+            return Err(io::Error::other("directory kill switch was activated"));
         }
         let guard = self.progress.protect_zone();
         Ok(guard)

quickwit/quickwit-common/src/net.rs

@@ -327,10 +327,9 @@ fn _get_hostname(hostname: OsString) -> io::Result<String> {
     if is_valid_hostname(&hostname_lossy) {
         Ok(hostname_lossy.to_string())
     } else {
-        Err(io::Error::new(
-            io::ErrorKind::Other,
-            format!("invalid hostname: `{hostname_lossy}`"),
-        ))
+        Err(io::Error::other(format!(
+            "invalid hostname: `{hostname_lossy}`"
+        )))
     }
 }
 

quickwit/quickwit-directories/src/bundle_directory.rs

@@ -113,8 +113,7 @@ impl BundleDirectory {
     pub fn open_split(split_file: FileSlice) -> io::Result<BundleDirectory> {
         // First we remove the hotcache from our file slice.
         let (body_and_bundle_metadata, _hot_cache) = split_footer(split_file)?;
-        BundleDirectory::open_bundle(body_and_bundle_metadata)
-            .map_err(|anyhow_err| io::Error::new(io::ErrorKind::Other, anyhow_err))
+        BundleDirectory::open_bundle(body_and_bundle_metadata).map_err(io::Error::other)
     }
 
     /// Opens a BundleDirectory, given a file containing the bundle data.

quickwit/quickwit-directories/src/storage_directory.rs

@@ -111,9 +111,9 @@ impl StorageDirectory {
 }
 
 fn unsupported_operation(path: &Path) -> io::Error {
-    let msg = "Unsupported operation. StorageDirectory only supports async reads";
-    error!(path=?path, msg);
-    io::Error::new(io::ErrorKind::Other, format!("{msg}: {path:?}"))
+    let error = "unsupported operation: `StorageDirectory` only supports async reads";
+    error!(error, ?path);
+    io::Error::other(format!("{error}: {}", path.display()))
 }
 
 impl Directory for StorageDirectory {

quickwit/quickwit-indexing/src/source/file_source.rs

@@ -30,7 +30,7 @@ use crate::source::{Source, SourceContext, SourceRuntime, TypedSourceFactory};
 
 enum FileSourceState {
     #[cfg(feature = "queue-sources")]
-    Notification(QueueCoordinator),
+    Notification(Box<QueueCoordinator>),
     Filepath {
         batch_reader: ObjectUriBatchReader,
         num_bytes_processed: u64,
@@ -180,7 +180,7 @@ impl TypedSourceFactory for FileSourceFactory {
             )) => {
                 let coordinator =
                     QueueCoordinator::try_from_sqs_config(sqs_config, source_runtime).await?;
-                FileSourceState::Notification(coordinator)
+                FileSourceState::Notification(Box::new(coordinator))
             }
             #[cfg(not(feature = "sqs"))]
             FileSourceParams::Notifications(quickwit_config::FileSourceNotification::Sqs(_)) => {

quickwit/quickwit-indexing/src/source/kafka_source.rs

@@ -785,11 +785,10 @@ mod kafka_broker_tests {
     }
 
     fn create_admin_client() -> AdminClient<DefaultClientContext> {
-        let admin_client = ClientConfig::new()
+        ClientConfig::new()
             .set("bootstrap.servers", "localhost:9092")
             .create()
-            .unwrap();
-        admin_client
+            .unwrap()
     }
 
     async fn create_topic(

quickwit/quickwit-ingest/src/mrecordlog_async.rs

@@ -59,10 +59,7 @@ impl MultiRecordLogAsync {
         .await
         .map_err(|join_err| {
             error!(error=?join_err, "failed to load WAL");
-            ReadRecordError::IoError(io::Error::new(
-                io::ErrorKind::Other,
-                "loading wal from directory failed",
-            ))
+            ReadRecordError::IoError(io::Error::other("loading wal from directory failed"))
         })??;
         Ok(Self {
             mrecordlog_opt: Some(mrecordlog),

quickwit/quickwit-jaeger/src/lib.rs

@@ -756,6 +756,7 @@ fn build_aggregations_query(num_traces: usize) -> String {
     query
 }
 
+#[allow(clippy::result_large_err)]
 fn qw_span_to_jaeger_span(qw_span_json: &str) -> Result<JaegerSpan, Status> {
     let mut qw_span: QwSpan = json_deserialize(qw_span_json, "span")?;
 
@@ -1027,6 +1028,7 @@ fn otlp_attributes_to_jaeger_tags_inner(
 
 /// Converts OpenTelemetry links to Jaeger span references.
 /// <https://opentelemetry.io/docs/specs/otel/trace/sdk_exporters/jaeger/#links>
+#[allow(clippy::result_large_err)]
 fn otlp_links_to_jaeger_references(
     trace_id: &TraceId,
     parent_span_id_opt: Option<SpanId>,
@@ -1058,6 +1060,7 @@ fn otlp_links_to_jaeger_references(
     Ok(references)
 }
 
+#[allow(clippy::result_large_err)]
 fn qw_event_to_jaeger_log(event: QwEvent) -> Result<JaegerLog, Status> {
     let timestamp = to_well_known_timestamp(event.event_timestamp_nanos);
     // "OpenTelemetry Event’s name field should be added to Jaeger Log’s fields map as follows: name
@@ -1087,6 +1090,7 @@ fn qw_event_to_jaeger_log(event: QwEvent) -> Result<JaegerLog, Status> {
     Ok(log)
 }
 
+#[allow(clippy::result_large_err)]
 fn collect_trace_ids(
     trace_ids_postcard: &[u8],
 ) -> Result<(Vec<TraceId>, TimeIntervalSecs), Status> {
@@ -1107,6 +1111,7 @@ fn collect_trace_ids(
     Ok((trace_ids, start..=end))
 }
 
+#[allow(clippy::result_large_err)]
 fn json_deserialize<'a, T>(json: &'a str, label: &'static str) -> Result<T, Status>
 where T: Deserialize<'a> {
     match serde_json::from_str(json) {
@@ -1120,6 +1125,7 @@ where T: Deserialize<'a> {
     }
 }
 
+#[allow(clippy::result_large_err)]
 fn postcard_deserialize<'a, T>(json: &'a [u8], label: &'static str) -> Result<T, Status>
 where T: Deserialize<'a> {
     match postcard::from_bytes(json) {