Remove config URI validation for read replica

Author: shuheiktgw

quickwit/quickwit-config/src/node_config/serialize.rs

@@ -374,17 +374,10 @@ fn validate(node_config: &NodeConfig) -> anyhow::Result<()> {
 
 /// Validates the configuration of the [`QuickwitService::MetastoreReadReplica`] role.
 ///
-/// When configured, `metastore_read_replica_uri` must be a PostgreSQL URI. The
-/// [`QuickwitService::MetastoreReadReplica`] role serves the same gRPC service as
+/// The [`QuickwitService::MetastoreReadReplica`] role serves the same gRPC service as
 /// [`QuickwitService::Metastore`], so the two cannot run on the same node, and the read-replica
 /// role requires `metastore_read_replica_uri` to connect to.
 fn validate_metastore_read_replica(node_config: &NodeConfig) -> anyhow::Result<()> {
-    if let Some(uri) = &node_config.metastore_read_replica_uri
-        && !uri.protocol().is_database()
-    {
-        bail!("`metastore_read_replica_uri` must point to a PostgreSQL database, got `{uri}`");
-    }
-
     let read_replica_enabled =
         node_config.is_service_enabled(QuickwitService::MetastoreReadReplica);
     if !read_replica_enabled {
@@ -1062,7 +1055,7 @@ mod tests {
     }
 
     #[tokio::test]
-    async fn test_metastore_read_replica_role_requires_postgres_uri() {
+    async fn test_metastore_read_replica_role_accepts_postgres_uri() {
         let config_yaml = r#"
             version: 0.8
             node_id: test-node
@@ -1128,42 +1121,6 @@ mod tests {
         );
     }
 
-    #[tokio::test]
-    async fn test_metastore_read_replica_uri_must_be_a_database() {
-        let config_yaml = r#"
-            version: 0.8
-            node_id: test-node
-            enabled_services:
-              - metastore_read_replica
-            metastore_read_replica_uri: s3://not-a-database
-        "#;
-        let error = load_node_config_with_env(
-            ConfigFormat::Yaml,
-            config_yaml.as_bytes(),
-            &Default::default(),
-        )
-        .await
-        .unwrap_err();
-        assert!(error.to_string().contains("must point to a PostgreSQL"));
-    }
-
-    #[tokio::test]
-    async fn test_metastore_read_replica_uri_must_be_a_database_even_without_role() {
-        let config_yaml = r#"
-            version: 0.8
-            node_id: test-node
-            metastore_read_replica_uri: s3://not-a-database
-        "#;
-        let error = load_node_config_with_env(
-            ConfigFormat::Yaml,
-            config_yaml.as_bytes(),
-            &Default::default(),
-        )
-        .await
-        .unwrap_err();
-        assert!(error.to_string().contains("must point to a PostgreSQL"));
-    }
-
     #[tokio::test]
     async fn test_metastore_and_read_replica_roles_are_mutually_exclusive() {
         let config_yaml = r#"