Commit 710aa11
Refactoring of the code maintaining ClusterNodes (#6466)
* Using Arc<str> for node ids.
* ClusterMember as a member in ClusterNode
* Marked ready_members_watcher as for test only
* Moved methods to deprecate in their own block
* Switched to chitchat 0.11
* Remove delegating methods from ClusterNode that duplicate ClusterMember fields via Deref
Methods removed: is_ready, grpc_advertise_addr, ingester_status, indexing_tasks, indexing_capacity.
All call sites updated to access fields directly through the existing Deref<Target = ClusterMember>.
Note: indexing_capacity() was an alias for the indexing_cpu_capacity field.
* Remove ready_members_rx watch channel and spawn_ready_members_task
The deprecated watch channel and background task maintained a redundant copy
of the ready member list. The test-only helpers (ready_members, wait_for_ready_members)
are reimplemented on top of the existing change_stream(), which already provides
consistent snapshots plus incremental updates under the write lock.
The test_single_node_cluster_readiness test is updated accordingly.
* Moving util methods from Node to Member
* Removing methods to build convert NodeId
* Cargo fmt + CR comment
---------
Co-authored-by: Paul Masurel <paul.masurel@datadoghq.com>1 parent 9a7b228 commit 710aa11
46 files changed
Lines changed: 632 additions & 668 deletions
File tree
- quickwit
- quickwit-cluster/src
- quickwit-config/src/node_config
- quickwit-control-plane/src
- indexing_scheduler
- scheduling
- ingest
- model
- quickwit-indexing
- failpoints
- src
- actors
- merge_policy
- source
- ingest
- queue_sources
- quickwit-ingest/src/ingest_v2
- broadcast
- quickwit-integration-tests/src/test_utils
- quickwit-janitor/src/actors
- quickwit-metastore/src/tests
- quickwit-proto/src/types
- quickwit-serve/src
- datafusion_api
- developer_api
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
109 | 109 | | |
110 | 110 | | |
111 | 111 | | |
112 | | - | |
| 112 | + | |
113 | 113 | | |
114 | 114 | | |
115 | 115 | | |
| |||
0 commit comments