Skip to content

Commit 710aa11

Browse files
Refactoring of the code maintaining ClusterNodes (#6466)
* Using Arc<str> for node ids. * ClusterMember as a member in ClusterNode * Marked ready_members_watcher as for test only * Moved methods to deprecate in their own block * Switched to chitchat 0.11 * Remove delegating methods from ClusterNode that duplicate ClusterMember fields via Deref Methods removed: is_ready, grpc_advertise_addr, ingester_status, indexing_tasks, indexing_capacity. All call sites updated to access fields directly through the existing Deref<Target = ClusterMember>. Note: indexing_capacity() was an alias for the indexing_cpu_capacity field. * Remove ready_members_rx watch channel and spawn_ready_members_task The deprecated watch channel and background task maintained a redundant copy of the ready member list. The test-only helpers (ready_members, wait_for_ready_members) are reimplemented on top of the existing change_stream(), which already provides consistent snapshots plus incremental updates under the write lock. The test_single_node_cluster_readiness test is updated accordingly. * Moving util methods from Node to Member * Removing methods to build convert NodeId * Cargo fmt + CR comment --------- Co-authored-by: Paul Masurel <paul.masurel@datadoghq.com>
1 parent 9a7b228 commit 710aa11

46 files changed

Lines changed: 632 additions & 668 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

quickwit/Cargo.lock

Lines changed: 31 additions & 22 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

quickwit/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ bitpacking = "0.9.3"
109109
bytes = { version = "1", features = ["serde"] }
110110
bytesize = { version = "2.3.1", features = ["serde"] }
111111
bytestring = "1.5"
112-
chitchat = "0.10.1"
112+
chitchat = "0.11.0"
113113
chrono = { version = "0.4", default-features = false, features = [
114114
"clock",
115115
"std",

0 commit comments

Comments
 (0)