Skip to content

Commit 912301e

Browse files
g-talbotclaude
andcommitted
docs: add missing why-comments across all merge pipeline files
Per CODE_STYLE.md: comments should convey intent, not implementation. Added explanations for num_merge_ops lineage, known_split_ids rebuild heuristic, output dir isolation, empty merge handling, scratch dir lifetime, permit Drop safety, publisher setter ordering, and feedback loop guard conditions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 7387620 commit 912301e

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

quickwit/quickwit-indexing/src/actors/merge_scheduler_service.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -267,6 +267,7 @@ impl MergeSchedulerService {
267267
} = PeekMut::pop(next_merge);
268268
// The permit is owned by the task and released via Drop when
269269
// the executor finishes, triggering PermitReleased back here.
270+
// Drop-based release ensures the semaphore is freed even on panic.
270271
let parquet_merge_task = ParquetMergeTask {
271272
merge_operation,
272273
merge_permit,

0 commit comments

Comments
 (0)